Kamil Śliwak
14adb7df3b
Really remove shellcheck ignore list
2021-03-15 20:02:42 +01:00
Kamil Śliwak
b8979a939c
Remove shellcheck ignore list
2021-03-15 12:16:43 +01:00
Kamil Śliwak
8e44b59251
Disable shellcheck in the remaining situations where it's either wrong or the problem is not worth fixing
2021-03-15 12:16:43 +01:00
Kamil Śliwak
008d648af3
Fix or disable find/ls related warnings
2021-03-15 12:16:43 +01:00
Kamil Śliwak
7929175db6
Add shellcheck source directive in places where it can't find sourced files on its own
2021-03-15 12:16:43 +01:00
Kamil Śliwak
978c25f1a4
Fix typos in isolate_tests.py
2021-03-10 20:42:46 +01:00
chriseth
eb85a4414c
Fix handling of carriage return.
2021-03-09 15:33:12 +01:00
Kamil Śliwak
cf94c3f7df
Remove scripts that now have no warnings from shellcheck ignore list
2021-03-04 16:57:25 +01:00
Kamil Śliwak
c8fc241be5
Avoid using $? in conditions and do && exit 1 instead if !
2021-03-04 16:57:25 +01:00
Kamil Śliwak
87f9eba1cf
docs_version_pragma_check.sh: Set SOLC only for the duration of compileFull
...
- This is a global variable and would be better to just make it a parameter. At least this makes shellcheck shut up
2021-03-04 16:57:25 +01:00
Kamil Śliwak
e8a70e8e4b
Prefix globs with ./ or use -- to make commands safe with files named like command-line options
2021-03-04 16:57:25 +01:00
Kamil Śliwak
7d845c0289
Don't use globs in command names
2021-03-04 16:57:25 +01:00
Kamil Śliwak
62bf467fc2
Fix warnings about constructions that have no effect
2021-03-04 16:53:05 +01:00
Kamil Śliwak
4e3ebda0f4
Don't use negative exit codes
2021-03-04 16:53:05 +01:00
Kamil Śliwak
dbfd3db038
Use mapfile instead of () for reading multiple lines as separate array items
2021-03-04 16:53:05 +01:00
Kamil Śliwak
d14c4288ec
Make scripts fail on non-zero return codes and undefined variables where possible
2021-03-04 16:53:05 +01:00
Kamil Śliwak
75b87d159d
Declare variables separately when assigning the result of $()
2021-03-04 16:53:05 +01:00
Kamil Śliwak
1c7cc376d1
Use "$@" instead of $*
2021-03-04 16:53:05 +01:00
Kamil Śliwak
4c186321c8
Replace some older shell syntax with newer and/or more reliable equivalents
2021-03-04 16:53:05 +01:00
Kamil Śliwak
8c57c7cb35
Explicitly use Bash in scripts that actually use non-POSIX features or do not have a shebang at all
2021-03-04 16:53:05 +01:00
Bhargava Shastry
1ddfc7463a
Tests: Do not remove filename from boost filesystem path for corner
...
cases.
Co-authored-by: Kamil Śliwak <kamil.sliwak@codepoets.it>
2021-02-22 10:32:41 +01:00
Alex Beregszaszi
f766700000
Remove unreachable warning for shift/exp operator
2021-02-16 13:17:58 +00:00
Alex Beregszaszi
efe3199981
Remove unreachable assertion for import resolution
2021-02-16 12:55:01 +00:00
Alex Beregszaszi
346344dc7b
Add missing test case for try/Catch
2021-02-16 12:33:55 +00:00
Alex Beregszaszi
ded5d721d2
Turn unreachable error into assertion
2021-02-16 10:59:22 +00:00
Alex Beregszaszi
fd9050614a
Remove untriggerable errors on variadic calls (which have been removed)
2021-02-15 22:45:57 +00:00
chriseth
c82c2189d4
Merge pull request #10877 from ethereum/bash-arrays-for-arg-variables
...
Use Bash arrays for argument lists in shell scripts
2021-02-08 13:31:31 +01:00
Kamil Śliwak
800c338534
Scripts for generating and comparing bytecode reports for solc-bin binaries
2021-02-03 19:15:52 +01:00
chriseth
8a4e6acdac
Merge pull request #10680 from ethereum/more-features-in-prepare-report
...
More features in prepare_report.py
2021-02-03 11:51:51 +01:00
Leonardo
d393624384
Merge pull request #10585 from ethereum/fix-quoting-and-whitespace-in-shell-scripts
...
Fix quoting in shell scripts
2021-02-03 11:27:40 +01:00
Kamil Śliwak
67fe5fb145
prepare_report.py: Print some statistics about contracts and errors
2021-02-02 16:16:28 +01:00
Kamil Śliwak
4576b1ec89
prepare_report.py: --exit-on-error option
2021-02-02 16:16:28 +01:00
Kamil Śliwak
acaab18a0a
prepare_report.py: More information on stdout, with verbosity control
2021-02-02 16:16:28 +01:00
Kamil Śliwak
96fd9051ed
prepare_report.py: Add --report-file option
2021-02-02 16:16:28 +01:00
Kamil Śliwak
7bebcb7871
prepare_report.js: Print ERROR in case of an exception during compilation instead of failing
...
- Our v0.4.11 release raises an exception on some LLL snippets containing returnlll (extracted from its end-to-end tests).
- The report comparison will fail anyway because emscripten prints an abort code to stdout in that case but at least we'll be able to continue if we're comparing multiple versions.
2021-02-02 16:16:14 +01:00
Kamil Śliwak
17fe96c4d0
prepare_report.py: Don't use --metadata option with compiler versions that do not support it
...
- Before 0.4.3 the option was unavailable but ignored.
- Between 0.4.3 and 0.4.6 an attempt to use that option causes an error.
2021-02-02 16:16:14 +01:00
Kamil Śliwak
49aede680b
prepare_report.py: Add --force-no-optimize-yul flag to work around a bug in solc 0.6.0/0.6.1
2021-02-02 16:16:14 +01:00
Kamil Śliwak
7e48aeb848
prepare_report.py: Make parsing more lax to handle output from older compiler versions
2021-02-02 16:16:14 +01:00
Kamil Śliwak
b06de9a2d5
prepare_report: Add command-line options for switching between SMT pragma stripping and only disabling the SMT checker
2021-02-02 16:16:14 +01:00
Kamil Śliwak
cba6e6814b
scripts/soltest.sh: Disable the warning about missing quotes around $DEBUGGER
...
- There are ways to fix the warning properly but they're all less readable than this in my opinion.
2021-02-02 15:45:24 +01:00
Kamil Śliwak
4a7d494d3c
Use Bash arrays for variables containing multiple space-separated values
2021-02-02 15:45:24 +01:00
Kamil Śliwak
c19464f908
Remove scripts that now have no warnings from shellcheck ignore list
2021-02-01 17:26:11 +01:00
Kamil Śliwak
27754d3e3d
Quote stuff properly
2021-02-01 17:14:38 +01:00
Kamil Śliwak
6d44055556
Fix inconsistent indentation
2021-02-01 17:03:05 +01:00
Kamil Śliwak
cd4b667545
post_style_errors_on_github.sh: Fix condition that sets $CIRCLE_PR_NUMBER
2021-01-28 12:41:26 +01:00
Kamil Śliwak
66d27f1ac6
Fix wrong script path in check_style.sh
...
- The script is actually in a subdirectory.
2021-01-28 12:37:33 +01:00
chriseth
46bb81d7ae
Merge pull request #10676 from ethereum/cli-bytecode-comparison
...
Bytecode comparison via CLI interface
2021-01-28 11:58:30 +01:00
Kamil Śliwak
b1f2d2994c
Fix badly placed comment in build_emscripten.sh
2021-01-27 11:46:46 +01:00
Kamil Śliwak
53f9a11440
prepare_report: Handle internal compiler errors in Standard JSON as errors, not missing bytecode
2021-01-26 23:30:38 +01:00
Kamil Śliwak
7f19339934
prepare_report.py: Add support for switching between CLI and Standard JSON compiler interfaces
2021-01-26 23:30:38 +01:00