Commit Graph
51 Commits
Author SHA1 Message Date
Daniel Kirchner c47da51eab Consider all grandparents in override analysis. 2022-02-14 15:31:31 +01:00
chriseth f7916f2940 Add override exception for interface functions. 2021-08-31 10:45:31 +02:00
Kamil Śliwak d96cc3469a FunctionDefinition.resolveVirtual(): Skip unimplemented functions when lookup happens via super 2021-06-02 16:16:15 +02:00
Kamil Śliwak 67e87147b4 Extra asserts, test renaming, test for super in modifiers 2021-06-02 16:15:51 +02:00
Alex Beregszaszi 1be07c2b36 Trivial isoltest updates: missing // ---- at the end 2021-04-20 17:38:29 +02:00
Alex Beregszaszi 84c05d35f3 Trivial isoltest updates: normalized whitespace 2021-04-20 17:38:29 +02:00
Mathias Baumann 3a8a74cbc7 OverrideSpecifier: Check for null before dereferencing 2021-02-04 13:17:28 +01:00
chriseth 79669ecd48 Use new abicoder pragma. 2020-11-24 14:57:45 +01:00
Daniel Kirchner 3f14c904b0 Disallow invalid use of library names as type names. 2020-10-16 18:25:08 +02:00
Mathias Baumann 446d15488c Update tests for new public var override rules 2020-07-20 15:18:23 +02:00
chriseth c8772a54c3 Constants are considered pure. 2020-07-20 15:18:23 +02:00
chriseth d3647b13e4 Disallow public state variables overriding pure functions. 2020-07-20 15:18:23 +02:00
Mathias L. Baumann 69a596b0ff Merge pull request #9418 from ethereum/stateMutForOverride
Issue state mutability restriction for overriding and not for virtual functions.
2020-07-20 15:01:25 +02:00
Mathias Baumann dfffecfe2c Allow overrides to have a more strict mutability than super 2020-07-16 17:55:12 +02:00
chriseth aa3f51ab47 Issue state mutability restriction for overriding and not for virtual functions. 2020-07-16 17:19:35 +02:00
chriseth 64b6524bdb Merge remote-tracking branch 'origin/develop' into breaking 2020-07-08 09:37:14 +02:00
chriseth 9743390a53 Update tests. 2020-07-07 12:16:18 +02:00
chriseth e48d3e5847 Fix wording of error message. 2020-07-06 19:22:52 +02:00
a3d4 e04cedafc5 Added error codes to SyntaxTest expectations (updated tests) 2020-06-22 16:51:47 +02:00
Mathias Baumann 6f8b5fe53b Disallow override with non-public state variables 2020-06-03 14:03:26 +02:00
Mathias Baumann a846c18e67 Fix failure to find overload resolution when overrides are involved 2020-05-27 18:31:56 +02:00
Daniel Kirchner fe659ceb41 Anything outside storage is always a pointer. 2020-03-23 15:34:10 +01:00
Leonardo Alt 1fb62b91d2 Add more override tests with public state variables 2019-12-11 15:15:51 +01:00
chriseth a5f7661075 Ambigous overrides for modifiers. 2019-12-09 18:43:59 +01:00
chriseth 152f42c6b2 Make ambigous override checker generic. 2019-12-09 18:41:39 +01:00
chriseth 6d2e59cc80 More tests. 2019-12-09 18:41:39 +01:00
chriseth e1d6ce2b66 Override checks for modifiers. 2019-12-09 18:41:39 +01:00
chriseth 06e8e216b3 Some more tests. 2019-12-09 16:04:45 +01:00
Daniel Kirchner 4c7f9f9751 Do not require overriding for functions in common base with unique implementation. 2019-12-09 16:04:45 +01:00
Mathias Baumann b7d5de59c5 Implement overridding of functions by public variables 2019-12-05 12:48:52 +00:00
Daniel Kirchner 426f04b389 Implement and fix overriding unimplemented and implemented functions with unimplemented functions. 2019-12-05 09:26:43 +01:00
Christian Parpart 7bbdfe070f Make shadowing of inherited state variables an error. 2019-12-03 21:20:03 +01:00
Daniel Kirchner 05baa23e8a Require unimplemented functions to be virtual. 2019-12-02 21:59:00 +01:00
Mathias Baumann 7bc6645218 Disallow use of virtual and private together 2019-11-27 18:52:41 +01:00
chriseth 0973ae751a Do not warn about enabled ABIEncoderV2 anymore. 2019-11-26 15:49:42 +01:00
Mathias Baumann 5b8ff78176 Implement virtual keyword 2019-11-14 11:49:39 +01:00
chriseth 7c258873bd Add some more abstract keywords in test to make sure the correct property is tested. 2019-11-04 17:26:38 +01:00
chriseth 5392532d70 Fix override error message. 2019-11-04 13:37:23 +01:00
Alexander Arlt cd3ad73b5a Update tests. 2019-11-01 14:54:47 -05:00
Mathias Baumann 6c6a9054b2 Implement override checking 2019-10-30 17:31:33 +01:00
Mathias Baumann 20e227afb5 Ensure list of overrides consists of contracts 2019-10-30 17:31:33 +01:00
Mathias Baumann 24716404f8 Parse override keyword 2019-08-26 17:34:21 +02:00
Daniel Kirchner 0e4912a203 ABIEncoderV2: Implement calldata structs without dynamically encoded members. 2019-02-11 15:46:58 +01:00
Daniel Kirchner 610ef9f199 Disallow calldata structs. 2019-01-21 10:30:57 +01:00
chriseth 0668a9ecfb Public state variables are implementing external functions. 2018-12-03 10:46:03 +01:00
chriseth 1e7a23a205 Changelog entry and tests. 2018-11-26 16:51:45 +01:00
Daniel Kirchner 597174119a Tests. 2018-11-26 14:30:32 +01:00
chriseth ac5803bf3e Changelog entry and tests. 2018-11-26 12:41:26 +01:00
Daniel Kirchner 4bcc4d2fcf Add additional test cases. 2018-08-01 17:18:17 +02:00
Erik Kundt 2e0d019ef0 Adds default visibility specifier to syntax tests. 2018-07-04 10:45:59 +02:00