Commit Graph

53 Commits

Author SHA1 Message Date
chriseth
f58024b974 Documentation about emitting events. 2018-02-22 15:17:42 +01:00
mirgj
d01786f0aa
Update solidity-by-example.rst
highestBidder is the address.
it's highestBid that should be != 0 to be considered as pending return.

It's that right?
2018-02-22 01:42:57 +08:00
Jim McDonald
93cf4dee66 Fixes for failing tests 2017-12-13 07:55:46 +00:00
Jim McDonald
6e521d59b0 Fix Solidity warnings 2017-12-12 18:47:30 +00:00
chriseth
d0be67f6b0
Bugfix in blind auction 2017-11-23 18:43:19 +01:00
William Morriss
d05b24162f also rm biddingTime 2017-10-08 13:40:18 -07:00
William Morriss
c3ec0beba5 remove auctionStart 2017-10-08 13:24:27 -07:00
Alex Beregszaszi
550d646b97 Explain safe purchase (even number) 2017-08-28 12:14:41 +01:00
Chim Kan
efe9d55ab2 Update on the example for BlindAction
In the Mist app, the Blind Action contract cannot compile because it cannot accept implicit conversion of integer to byte32. I just added the conversion method byte32 in line 470 for bid.blindedBid.
2017-08-24 12:03:27 -04:00
Chim Kan
b5d2a4ecd7 Adding storage into the pointer for Voter delegate
Hi,

The example from https://github.com/ethereum/solidity/blob/develop/docs/solidity-by-example.rst is not working. 

It keeps giving this error in the Mist program:

     Could not compile source code. 

     Variable is declared as a storage pointer. Use an explicit "storage" keyword to silence this warning.
            Voter delegate = voters[to];
            ^------------^

The solution is just to add the keyword "storage" and then the example works again.
2017-08-23 20:25:12 -04:00
Adrián Calvo
8d832c7cd3 Removes reference to stack depth attack
Changed the old stack depth attack reference to a generic execution of an untrusted contract to keep the suggestion of the withdrawal pattern.
2017-08-04 14:08:37 +02:00
Alex Beregszaszi
318e52c77d Avoid using .send in the examples 2017-07-26 23:05:09 +01:00
Alex Beregszaszi
48a15ea19d Use the storage keyword in examples 2017-07-26 23:05:09 +01:00
Alex Beregszaszi
6eaf17db38 Avoid using var if not required 2017-07-26 23:05:09 +01:00
Luke Schoen
56b65cf846 Update solidity-by-example.rst. Fixes accepted bids
Only accept bid values higher than highest bid. Since returns early from `placeBid` function if `value <= highestBid`
2017-07-17 19:58:41 +10:00
Dillon Arevalo
552f2e5303 Add weight == 0 condition to giveRightToVote function
This will make it so votes can't be deleted accidentally by giving someone with weight > 1 the right to vote again
2017-06-20 20:48:49 -07:00
Yoichi Hirai
2f3aaa46e9 Merge pull request #2315 from pjstadig/patch-1
Fix typo
2017-05-26 13:16:14 +02:00
Paul Stadig
2e46383b29 Fix typo 2017-05-25 17:17:47 -04:00
Alexey Alexeyeff
f4ee578b9a Rename events in purchase example
Rename events in purchase example according to style guide
2017-05-25 19:41:40 +03:00
chriseth
a0d0776bbc Fix typo.
Fixes #2273
2017-05-17 11:20:46 +02:00
chriseth
e9458be7bd Parentheses. 2017-05-03 11:07:15 +01:00
chriseth
d58a4e08da Corrections and some style. 2017-05-03 11:07:15 +01:00
chriseth
7e838fd4a8 Cleanup to make the docs more consistent. 2017-05-03 12:03:02 +02:00
Matt Wisniewski
2b4b86aa7f Update common-patterns.rst 2017-05-03 12:03:02 +02:00
Abraham Sangha
98242f5409 minor: fix formatting and grammar 2017-04-14 19:05:53 -06:00
Remo Fürst
b5c17d7058 Fix delegation loop in Ballot example contract
fixes #1753
2017-03-08 22:45:27 +01:00
varunagarwal315
364698255a Update solidity-by-example.rst
added the space. Sorry, just slipped my mind.
2016-11-03 22:25:19 +05:30
varunagarwal315
38e0b0a5fa Update solidity-by-example.rst
made changes suggested to simplify code. Hope this is enough

Thanks
2016-11-03 17:42:05 +05:30
varunagarwal315
4c105dba07 Update solidity-by-example.rst
Might be trivial, but makes more sense to be able to directly return the name of the winner for the election. If the position of the winner on the proposal[] array is returned, then people still don't know the name of the person who won.
2016-11-03 13:02:25 +05:30
Alex Beregszaszi
111d33d7ac Rename sha3 to keccak256 in the documentation 2016-10-06 16:34:41 +02:00
chriseth
4f5a95d569 Update documentation to version 0.4.0. 2016-09-06 19:11:41 +02:00
chriseth
453490cb61 Merge pull request #1003 from winsvega/docs
add "pragma solidity ^0.4.0;" to code examples
2016-09-06 15:59:49 +02:00
chriseth
02984b8de1 Require ";" after "_" 2016-09-05 14:54:50 +02:00
Dimitry
183cd70c47 add "pragma solidity ^0.4.0;" to code examples 2016-09-05 14:54:54 +03:00
Denton Liu
532266b89e Use new style for the docs 2016-08-26 13:33:42 -04:00
chriseth
c2665dc2fe Merge pull request #913 from chriseth/auction
Updated the function withdraw() in the SimpleAuction and BlindAuction…
2016-08-24 23:17:04 +02:00
Alex Darby
41eaf3a0cc Updated the function withdraw() in the SimpleAuction and BlindAuction contracts to not use a 'throw' if a address send() fails. 2016-08-18 18:00:30 +02:00
Denton Liu
a6c9d85399 Remove trailing whitespace 2016-08-10 10:42:51 -04:00
Denton Liu
efb48659dd Add section about withdrawal pattern 2016-08-10 10:40:55 -04:00
chriseth
2df142c496 Security Considerations 2016-07-04 15:27:53 +02:00
chriseth
39c031bfca Typo. 2016-06-09 00:36:31 +02:00
chriseth
ed9cc5476e style 2016-06-01 23:40:38 +02:00
chriseth
f9c8a9b5ca Removed some problems in documentation examples. 2016-05-31 13:56:16 +02:00
Denton Liu
49f5bc7ce9 Changed inline code syntax
Changed from :code:`<inline>` to ``<inline>``
2016-05-30 09:44:33 -04:00
Denton Liu
b3669e6394 Corrected solidity-by-example.rst
Fixed inline code syntax
2016-05-30 09:44:33 -04:00
Mathieu Van der Haegen
0a9c95c53d Typo correction in solidity-by-example.rst
Just correcting a simple typo in the comments of the code
2016-05-26 14:43:00 +02:00
Denton Liu
7c22a387f3 Changed whitespace formatting 2016-05-18 11:35:32 -04:00
Denton Liu
d4ad3231a2 Removed trailing whitespace 2016-05-18 11:35:32 -04:00
Denton Liu
961eb53f41 Moved the location of the "||" 2016-05-06 09:40:05 -04:00
Denton Liu
ffade949de Fixed up formatting 2016-05-05 15:31:00 -04:00