Commit Graph

22425 Commits

Author SHA1 Message Date
Daniel Kirchner
3015afc504 Change severity of inline assembly bug to medium. 2022-06-13 17:18:13 +02:00
Daniel Kirchner
efcbc79b1c
Merge pull request #13100 from ethereum/fixUnusedStoreInlineAssembly
Fix unused store inline assembly
2022-06-10 22:56:44 +02:00
Daniel Kirchner
aa7e4e02bb A few more tests. 2022-06-10 20:12:09 +02:00
Daniel Kirchner
94dd6d0671 Bug list entry draft.
Co-authored-by: Kamil Śliwak <kamil.sliwak@codepoets.it>
2022-06-10 20:05:14 +02:00
chriseth
51ef6a62da Fix removal of memory stores in inline assembly blocks. 2022-06-10 17:32:28 +02:00
chriseth
14cdb76e4b Add failing test 2022-06-10 17:32:28 +02:00
Kamil Śliwak
80f6a13d65
Merge pull request #13075 from ethereum/add-more-info-to-failed-semantic-tests
Print settings options such evmVersion and optimize in isoltest/soltest failed test logs.
2022-06-09 17:05:01 +02:00
Matheus Aguiar
f15e53ce4d Added printSelectedOptions and toString as method of CommonOptions and used the former to print settings in failed semanticTests. 2022-06-09 11:19:46 -03:00
Daniel Kirchner
01a794dd31
Merge pull request #13117 from ethereum/fixEmptyLinesInDocs
Remove all-whitespace lines from docs.
2022-06-09 15:41:47 +02:00
Mathias L. Baumann
cf1b9a5241
Merge pull request #13109 from sourabhxyz/develop
Fix commandline tests not detecting a snippet with a broken free function definition
2022-06-09 15:31:54 +02:00
Daniel Kirchner
4576333245 Remove all-whitespace lines from docs. 2022-06-09 15:00:03 +02:00
Kamil Śliwak
ef2aa59f63
Merge pull request #13115 from denis-t-dev/patch-1
Fix comment position in the voting example
2022-06-09 14:53:47 +02:00
Denis T
811fa193af
Fix comment position in the voting example 2022-06-09 15:09:02 +03:00
Kamil Śliwak
9b220a2007
Merge pull request #12575 from ethereum/gnosis-gp-v2-ext-test
External test for Gnosis Protocol v2
2022-06-08 21:42:30 +02:00
Kamil Śliwak
e777ec9013
Merge pull request #12580 from ethereum/chainlink-ext-test
External test for Chainlink
2022-06-08 21:42:05 +02:00
Kamil Śliwak
8e67b28e0f Make the checks that detect if a docs snippet should compile a bit more robust against comments 2022-06-08 21:32:30 +02:00
sourabh.xyz
8405d167c1 using-for.rst: Fix free function visibility.
Example is incorrect in the sense that "Free functions" cannot have visibility specified.
2022-06-08 21:32:30 +02:00
Kamil Śliwak
0b80a56294 External test for Gnosis Protocol v2 2022-06-08 20:23:39 +02:00
Kamil Śliwak
5c76d8ee77 External test for Chainlink 2022-06-08 20:21:58 +02:00
Daniel Kirchner
bbfef2dd6b
Merge pull request #13005 from StrongerXi/fix-typechecker-for-custom-error
Display human readable type name in conversion error message
2022-06-08 16:14:19 +02:00
Ryan
4b7ed2d47a Display human readable type name in conversion error message 2022-06-08 18:23:51 +05:30
Daniel Kirchner
f2c930588c
Merge pull request #13079 from uji/sort-grammer-rules
Sort grammar rules of SolidityLexer.g4
2022-06-08 12:55:59 +02:00
Christian Parpart
8c87f58fa5
Merge pull request #13102 from ethereum/cpp-unreachable
Better way to annotate unreachability in C++
2022-06-07 17:22:52 +02:00
Christian Parpart
4ae43884d0 Apply a better way to annotate unreachability to the C++ compiler. 2022-06-07 16:41:04 +02:00
Christian Parpart
927da20ce4 Adds solidity::util::unreachable() helper function. 2022-06-07 16:40:55 +02:00
Christian Parpart
87f5865fb0
Merge pull request #13093 from ethereum/lsp.py-fixes
lsp.py: Add missing check for non-interactive
2022-06-07 16:13:22 +02:00
Marenz
9c4ea1dc68 lsp.py: Add missing check for non-interactive 2022-06-07 15:30:14 +02:00
Kamil Śliwak
95f22db175
Merge pull request #13097 from ethereum/skipping-ext-benchmark-diff
Skipping benchmark diff when previous run failed
2022-06-07 14:46:01 +02:00
Kamil Śliwak
2cea70c04f Skip external test benchmark diff instead of failing when previous run of the job did not succeed 2022-06-07 13:24:55 +02:00
Damian Wechman
64979c1119
Merge pull request #13081 from ethereum/cse-optimization-changelog
Update changelog with information about changes to CommonSubexpressionEliminator
2022-06-07 13:18:38 +02:00
wechman
f40c9cdf1d Update changelog with information about changes to CommonSubexpressionEliminator 2022-06-07 11:53:43 +02:00
a3d4
423f3d3088 Fix ICE caused by an immutable struct 2022-06-07 10:29:45 +02:00
Kamil Śliwak
3948391ca8
Merge pull request #13092 from ethereum/disable_zepplin_tests_broken_via_ir_due_to_hardhat_heuristics
Disabling more OpenZeppelin tests that expect reverts with specific error
2022-06-06 20:32:09 +02:00
nishant-sachdeva
61306a6f9d disabling more zeppline tests that expect reverts with specific errors and they're broken via IR due to Hardhat heuristics.
Updated zeppelin.sh

Added cautionary comment for two sed commands that depend on the order of occurrence of the patterns in the files.
L122, and L123 both are referencing the 3rd occurrence of the patterns from their respective files.
This could result in an error in the future when the code is further modified.
2022-06-06 19:15:40 +05:30
Kamil Śliwak
035f6abb1b
Merge pull request #13094 from yurivict/fix-missing-include
Fix missing STL include in tools/solidityUpgrade/SourceUpgrade.cpp
2022-06-02 20:23:17 +02:00
Yuri Victorovich
54ac1e8240 Fix missing STL include in tools/solidityUpgrade/SourceUpgrade.cpp 2022-06-02 09:43:18 -07:00
Kamil Śliwak
1f8b8c98d2
Merge pull request #13087 from ethereum/gcc-12-control-reaches-end-of-function-warning-workaround
Workaround for the spurious `control reaches end of non-void function` warning in GCC 12.1
2022-06-02 14:59:01 +02:00
Kamil Śliwak
3f84837e0b
Merge pull request #13088 from ethereum/fix-new-pylint-warnings-after-upgrade
Fix new warnings from pylint 2.14 and adjust pylint config
2022-06-01 21:15:56 +02:00
Kamil Śliwak
e19e6ad806 Remove empty assertion messages in a fews places 2022-06-01 20:37:48 +02:00
Kamil Śliwak
539e139555 Add explicit throws after some assertions to work around a spurious warning in GCC 12.1 2022-06-01 20:37:48 +02:00
Kamil Śliwak
f5e421ff91 pylintrc: Remove bad-whitespace form the list of disabled warnings
- pylint complains that it's not a valid value and removing it does not make any new warnings appear
2022-06-01 20:32:25 +02:00
Kamil Śliwak
6605dd084a gas_diff_stats.py: Replace a list with a generator as suggested by pylint 2022-06-01 20:32:25 +02:00
Kamil Śliwak
f4f4cfe294 CI: Print pylint version before running checks 2022-06-01 20:32:25 +02:00
chriseth
a90bafd44d
Merge pull request #13083 from ethereum/lsp.py-fixes
lsp.py: Fix various problems with subdirectory edge cases
2022-06-01 13:16:43 +02:00
Kamil Śliwak
baf56aff40
Merge pull request #13076 from PrajwalBorkar/develop
Updated broken link for Yul optimizations
2022-05-31 16:25:14 +02:00
Marenz
6c9754a784 lsp.py: Fix various problems with subdirectory edge cases
* fix properly path parsing with nested subdirectories
* fix regex to be able to handle `file://..`
* fix not checking all expected diagnostics
* Some extra comments and renames
2022-05-31 16:17:35 +02:00
Prajwal Borkar
6061219641 Fix link to the optimizer step sequence in optimizer.rst 2022-05-31 15:41:22 +02:00
Kamil Śliwak
96398ee3ee
Merge pull request #13084 from ethereum/revert-workaround-euler-test
Revert workaround introduced in euler tests because it is no longer needed
2022-05-31 15:26:34 +02:00
Matheus Aguiar
3904a0d5ce Revert workaround introduced in euler tests because it is no longer needed.
This reverts commit 98efb46031.
2022-05-31 09:00:00 -03:00
uji
5f6f353953 Sort grammer rules of SolidityLexer.g4 2022-05-30 00:15:48 +09:00