Braden Watling
bb16c1943c
Fix gas retaining statement.
...
According to https://docs.soliditylang.org/en/v0.8.11/introduction-to-smart-contracts.html?highlight=63%2F64#message-calls , the caller forwards 63/64th of its gas, but here we seem to contradict that by saying the caller retains 63/64th of its gas.
2022-01-04 11:10:31 +01:00
hrkrshnn
85d1a57e65
Added more tests. Updated chromosome. Remove unused headers.
2022-01-04 13:27:39 +05:30
Harikrishnan Mulackal
96f06d29c2
Merge pull request #12485 from bradenwatling/patch-1
...
Fix typo in control-structures.rst
2022-01-04 11:50:37 +05:30
Braden Watling
6fe1ee6a8a
Fix typo in control-structures.rst
...
I'm learning Solidity by reading these docs and found this statement confusing. I'm fairly certain that the correct description here is that the *callee* changes get reverted, but the caller is able to react to the failures.
I tested this with the following snippet in Remix, which resulted in a successful transaction when deployed:
```
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.7;
contract A {
uint public value;
function a(uint newValue, bool shouldRevert) external {
value = newValue;
if (shouldRevert) {
revert();
}
}
}
contract B {
function b() external {
A a = new A();
try a.a(50, false) {
assert(a.value() == 50);
} catch {
assert(false);
}
a = new A();
try a.a(50, true) {
assert(false);
} catch {
assert(a.value() == 0);
}
}
}
```
2022-01-03 17:22:23 -05:00
chriseth
c28f85f1e2
Merge pull request #12484 from ethereum/fix-interpreter-mem-overflow-bug
...
Impose stricter upper bound on memory accesses in order to prevent wrap around
2022-01-03 19:16:09 +01:00
Bhargava Shastry
259a98b82c
Impose stricter upper bound on memory accesses in order to prevent overflow/wrap around.
2022-01-03 18:22:42 +01:00
chriseth
b8ee17340b
Merge pull request #12481 from ethereum/internalLibraryCallsCode
...
Clarify which functions are added.
2022-01-03 16:44:56 +01:00
chriseth
b354c81a63
Documentation
2022-01-03 15:52:05 +01:00
chriseth
e7fc2a176a
Test updates.
2022-01-03 15:52:05 +01:00
chriseth
772e100813
Equal store eliminator.
2022-01-03 15:52:05 +01:00
chriseth
57474917a0
Clarify which functions are added.
2022-01-03 15:38:39 +01:00
Daniel Kirchner
e5f912ec89
Add static z3 build and version check to release checklist.
2022-01-03 15:36:27 +01:00
Daniel Kirchner
5597d43635
Add impish to static Z3 PPA script.
2022-01-03 14:03:40 +01:00
Harikrishnan Mulackal
223395bcad
Merge pull request #12477 from 0xpranay/patch-1
...
Added specificity to data location.
2022-01-03 13:34:49 +05:30
Pranay Reddy
f30130888e
Added specificity to data location.
...
Added the specificity that bytes1[] and bytes differ because of padding only in memory data location. Added extra sentence that they are similar when used in storage data location.
2022-01-03 12:47:51 +05:30
chriseth
0010027e17
Fix mapping example.
2021-12-30 15:28:09 +01:00
chriseth
2a7f26e2c0
Test batcher.
2021-12-30 15:02:05 +01:00
chriseth
6849774bd7
Merge pull request #12456 from nishant-sachdeva/generate_warning_if_isoltest_gas_cost_expectations_not_enforced
...
added warning if isoltest gas-cost-expectations are not enforced
2021-12-30 14:59:45 +01:00
nishant-sachdeva
bd819c87fa
added warning if isoltest gas-cost-expectations are not enforced
2021-12-30 18:51:55 +05:30
chriseth
692614df72
Merge pull request #12437 from ethereum/encodeCallForDeclarations
...
abi.encodeCall for declarations.
2021-12-29 18:40:18 +01:00
chriseth
563357cfec
Merge pull request #12464 from ethereum/franzihei-patch-1
...
[DOCS] update contributing section meeting link
2021-12-29 18:04:27 +01:00
Franziska Heintel
4456eeb6bb
[DOCS] update contributing section meeting link
2021-12-29 16:06:05 +01:00
Leo
048a8f4d28
Merge pull request #12455 from ethereum/smt_analyze_contracts
...
[SMTChecker] Do not analyze unecessary contracts
2021-12-29 15:14:35 +01:00
chriseth
7c4f4ae46c
Merge pull request #12461 from ethereum/cleanup-modifier-resolve
...
[trivial] Remove unnecessary checks in modifier resolve function
2021-12-29 14:28:52 +01:00
Marenz
b95db2db5e
Remove unnecessary checks in modifier resolve function
2021-12-29 13:27:10 +01:00
chriseth
4c838d9cf5
abi.encodeCall for declarations.
2021-12-29 12:26:04 +01:00
Leo Alt
fb8c138b8b
Do not analyze unecessary contracts
2021-12-24 19:36:32 +01:00
chriseth
7620bfaad8
Add option member for function type.
2021-12-23 12:05:18 +01:00
chriseth
f94279a437
Use options struct for function type factory function.
2021-12-23 12:05:14 +01:00
chriseth
4fa8eee683
Use function names instead of members.
2021-12-23 11:55:33 +01:00
Kamil Śliwak
b28cd00aa0
Merge pull request #12198 from ethereum/switch-ens-ext-test-to-ens-contracts
...
Switch ENS external test to ens-contracts repo
2021-12-22 16:38:15 +01:00
Kamil Śliwak
7e91dba663
Switch ens external test to ens-contracts repo
2021-12-22 14:45:51 +01:00
chriseth
1582682626
Merge pull request #12444 from ethereum/pylint-disable-too-many-warnings
...
[pylint] Disable the opinionated too-many-xyz warnings
2021-12-21 19:27:37 +01:00
Kamil Śliwak
de364c566c
pylint: Disable the opinionated too-many-xyz warnings
2021-12-21 18:37:38 +01:00
chriseth
0769e4df5d
Merge pull request #12445 from ethereum/pylint-enable-more-warnings
...
[pylint] Enable more warnings
2021-12-21 18:20:52 +01:00
chriseth
4149560be1
Merge pull request #12446 from ethereum/fix-eslint-warnings-in-external-test-js
...
Fix ESLint warnings/errors in external test JS
2021-12-21 17:06:06 +01:00
Kamil Śliwak
8cfecb45cc
Fix ESLint warnings/errors in external test JS
2021-12-21 16:18:46 +01:00
chriseth
ef6dd2ec50
Merge pull request #12433 from ethereum/removeConstexpr
...
Remove constexpr.
2021-12-21 16:03:58 +01:00
Kamil Śliwak
589f4b2a83
pylint: Enable bad-continuation and ungrouped-imports warnings and update the list of warnings to eliminate in the future
2021-12-21 15:31:01 +01:00
Kamil Śliwak
dece5f4de2
pylint: Enable and fix redefined-builtin warnings
2021-12-21 15:30:11 +01:00
Kamil Śliwak
5b10ff1216
pylint: Enable and fix singleton-comparison warnings
2021-12-21 15:30:11 +01:00
Kamil Śliwak
784ae91b41
pylint: Enable and fix no-self-use warnings
2021-12-21 15:30:11 +01:00
Kamil Śliwak
449f56c15b
pylint: Enable and fix consider-using-sys-exit warnings
2021-12-21 15:30:11 +01:00
Kamil Śliwak
b65e093394
Merge pull request #12438 from ethereum/documentnodejsversionchange
...
Document nodejs required version change.
2021-12-20 21:17:46 +01:00
chriseth
a4b2fc9cb7
Merge pull request #12361 from mejsiej/improved-err-msg-when-getter-returns-nothing
...
Changed the message of the error thrown when the structure has all it's members omitted
2021-12-20 21:06:14 +01:00
chriseth
e5d7b81ca6
Merge pull request #12397 from ethereum/enable-ext-test-presets-that-compile-but-fail-tests
...
Enable external test presets that compile but fail tests
2021-12-20 20:05:53 +01:00
chriseth
1cb9766835
Document nodejs required version change.
2021-12-20 19:39:05 +01:00
Kamil Śliwak
1124e28628
externalTests: With COMPILE_ONLY=1 still do compilation on all levels if only JS tests fail
2021-12-20 19:14:37 +01:00
chriseth
113ecbdeb3
Merge pull request #12408 from sbillig/fix-mac-build
...
Update circleci mac xcode version to 13.2
2021-12-20 18:49:22 +01:00
mejsiej
ddd9a84141
Improve failure message when generating getter.
2021-12-20 18:16:27 +01:00