Commit Graph
21953 Commits
Author SHA1 Message Date
chriseth 7ab4ee1b25 Merge pull request #12623 from theNvN/develop
plain `address` can be sent Ether too
2022-02-07 12:45:30 +01:00
Naveen Sahu 2e2094ad82 plain address can be sent Ether too
The docs state that a plain `address` cannot be sent Ether. But even though `send` and `transfer` members are not available for plain `address`, the `call` is. And `call` can be invoked upon a plain `address` type to send Ether to the address.

For instance, the `someone` (`address` type) can be sent Ether by invoking `sendSomeone()` method in the following `Dummy` contract:

```
contract Dummy {
    address someone = 0xAb8...cb2;

    function balanceOf(address addr) public view returns (uint) {
        return addr.balance;
    }

    function sendToSomeone() public payable returns (bool) {
        (bool sent, ) = someone.call{value: msg.value}("");
        return sent;
    }
}
```
2022-02-07 12:44:21 +01:00
chriseth 6a7da2104f Merge pull request #12626 from nishant-sachdeva/allowing_string_concat_operations
removed comment from Types.h after previous PR rendered it incorrect
2022-02-07 12:40:23 +01:00
Marenz b9fe628b70 Emit immutable references for pure yul code 2022-02-07 12:32:54 +01:00
chriseth 5dc7a38449 Merge pull request #12640 from ethereum/reenablepooltogether
Re-enable preset for poolTogether.
2022-02-07 12:29:13 +01:00
chriseth 4715fafb82 Re-enable preset for poolTogether. 2022-02-07 11:31:59 +01:00
Daniel Kirchner 6b8654384c Merge pull request #12625 from shuklaayush/patch-1
Docs: fix slot calculation for mappings of strings/byte arrays
2022-02-07 10:54:05 +01:00
Hakeem Almidan c3145979fc Update cheatsheet.rst
Add more description to the bullet point of 'block.timestamp' (under 'Global Variables')
2022-02-06 20:16:04 +03:00
William Entriken 6bd38aa4ef Fix signature of pop member 2022-02-05 23:59:09 -05:00
a3d4 a0dd2cd1ff Remove a reference to unused SolidityFixedFeeRegistrar 2022-02-05 15:14:18 +01:00
a3d4 0a17495cf9 Treat root path in normalizeCLIPathForVFS as case insensitive on Windows 2022-02-05 11:51:11 +01:00
a3d4 7634fc4ea9 Clarify symlink handling on Windows 2022-02-05 03:44:54 +01:00
Kamil Śliwak 2f0ccb21be CI: Switch t_ems_ext_hardhat to nodejs 16 2022-02-05 00:31:17 +01:00
Kamil Śliwak 247eab9056 CI: Rename node_latest_small to node_small 2022-02-05 00:06:23 +01:00
Kamil Śliwak 4d65bfa95e CI: Remove notes about Hardhat failing on nodejs 17; that version is officially not supported 2022-02-05 00:06:23 +01:00
Ayush Shukla 653c1e6842 Fix slot calculation for bytes/string mapping 2022-02-05 01:00:27 +05:30
Kamil Śliwak 32d64ce666 Merge pull request #12630 from ethereum/enable-full-tests-in-prb-math-ext-test
Enable full tests in PRBMath external test
2022-02-04 16:56:31 +01:00
Kamil Śliwak 4ebd839d3a Run full tests, not just test:contracts in PRBMath external test
- `test:contracts` does not seem to be running any tests at all.
2022-02-04 15:51:34 +01:00
Kamil Śliwak c70f8c5496 Merge pull request #12629 from ethereum/reenable-bleeps-ext-test-without-governor-test
Re-enable Bleeps external test without the failing governor test
2022-02-04 15:51:21 +01:00
Kamil Śliwak b52032a452 Re-enable Bleeps and just disable the failing governor test 2022-02-04 15:18:37 +01:00
Kamil Śliwak 93d5b79e5c Merge pull request #12599 from ethereum/docs-resources
[DOCS] Adding a few resources to resources section
2022-02-04 15:06:34 +01:00
Kamil Śliwak 9e641e60e7 externalTests/solc-js: Allow using a local checkout of solc-js 2022-02-04 15:05:00 +01:00
Kamil Śliwak b925250705 Make solc-js.sh run its tests directly
- Its structure has diverged a lot from other external tests and there's not point in keeping it abstracted like this.
2022-02-04 15:05:00 +01:00
Daniel Kirchner afc3d72e81 Merge pull request #12624 from ethereum/adjust-solc-js-installation
Adjust solc-js installation to match the new release process
2022-02-04 12:26:05 +01:00
nishant-sachdeva e85bceb417 Types.h:872 had a comment /// String is interpreted as a subtype of
Bytes. - this was now incorrect after #12593 . That has been removed
now.
2022-02-04 15:49:08 +05:30
Kamil Śliwak f5b345504b When installing solc-js use the dist/ subdir, which contains the built JS files 2022-02-03 18:47:19 +01:00
chriseth 2b141c23ba Merge pull request #12618 from fulldecent/develop
Add NatSpec note for libraries
2022-02-03 18:23:29 +01:00
chriseth 08650c4dc7 Merge pull request #12595 from ethereum/adjust-release-checklist-for-new-solc-js-publish
Update release checklist for new solc-js publish process
2022-02-03 13:43:42 +01:00
Nishant Sachdeva 89bb79b57a Merge pull request #12593 from nishant-sachdeva/allowing_string_concat_operations
Changed interpretation of isByteArray() to return True only for Byte Type. 
Cases where both Byte And String Types are required have been provided with isByteArrayOrString() function.
2022-02-03 17:53:48 +05:30
William Entriken dcaa094f1f Add NatSpec note for libraries 2022-02-02 18:11:14 -05:00
nishant-sachdeva cc6344c03c Changed instaces of isByteArrayOrString() to isByteArray() where it's only supposed to return a True for Bytes Type 2022-02-02 17:05:26 +05:30
nishant-sachdeva 9043621747 Changed occurences of isByteArray() to isByteArrayOrString(). The idea
is to, in a future commit, replace such occurences of
isByteArrayOrString() which are required to return True only for Bytes
type with a new isByteArray() function.
2022-02-02 14:19:58 +05:30
Kamil Śliwak a05d2b356a Merge pull request #12611 from ethereum/fix-bleeps-and-perpetual-pools
Fix breakage in Bleeps and Perpetual Pools external tests
2022-02-01 19:26:31 +01:00
Kamil Śliwak 1e0a695d24 Disable bleeps external test until it gets fixed upstream 2022-02-01 17:01:10 +01:00
Kamil Śliwak e1a90b829e bleeps: Patch WETH9.sol for 0.8.x 2022-02-01 16:40:28 +01:00
Kamil Śliwak 57800529d1 bleeps: Switch to the main branch 2022-02-01 16:40:08 +01:00
Kamil Śliwak 6788f77541 Add missing SELECTED_PRESETS argument to some of the recently added external tests 2022-02-01 15:25:13 +01:00
Kamil Śliwak 1528d4b9e4 perpetual-pools: Switch the test to our fork (original repo is gone) 2022-02-01 14:34:03 +01:00
chriseth f4e0270374 Merge pull request #12605 from nishant-sachdeva/indexed_log_topic_differs_between_legacy_and_ir_if_explicitly_downcast
Code generators needed fixing of the cleanup process during typecasting of bytes and integers
2022-02-01 12:35:10 +01:00
nishant-sachdeva e2711b7fab Corresponding code in the .cpp file has been commented instead of begin removed pending preliminary reviews
Code generators needed fixing of the cleanup process during typecasting of bytes and integers
2022-02-01 16:07:55 +05:30
Daniel Kirchner e87d959f48 Merge pull request #12606 from ethereum/chriseth-patch-1
[docs] Correct type of address.code
2022-02-01 11:02:10 +01:00
Kamil Śliwak d839624f51 Merge pull request #12607 from ethereum/chriseth-patch-2
Fix changelog for the bugfix about immutables with return in base constructor
2022-01-31 21:15:14 +01:00
franzihei 8bcc4ee7d1 Adding a few resources 2022-01-31 20:21:42 +01:00
chriseth b1e1b4df32 Merge pull request #12229 from ethereum/fixValueOrDefault
Fix util::valueOrDefault.
2022-01-31 20:05:42 +01:00
Daniel Kirchner 73470aed6a Fix util::valueOrDefault. 2022-01-31 19:33:09 +01:00
chriseth 4259e1bb70 Fix changelog 2022-01-31 19:19:16 +01:00
chriseth 8728971354 Correct type of address.code 2022-01-31 19:07:01 +01:00
Kamil Śliwak f1ce1528bb Update the release checklist to use the build+publish commands for solc-js 2022-01-31 18:54:07 +01:00
chriseth fd68cb1715 Merge pull request #12579 from ethereum/fix-memory-copy-bug
[Sol2Yul] Fixed an ICE on struct member copy
2022-01-31 18:04:07 +01:00
hrkrshnn 0fe5811459 Fixed a ICE on calldata to struct member copy 2022-01-31 17:26:11 +01:00