Commit Graph

21968 Commits

Author SHA1 Message Date
Leo Alt
9f171c0f06 update smtchecker tests for new z3 2022-01-12 15:13:34 +01:00
Harikrishnan Mulackal
a711969983
Merge pull request #12511 from ethereum/deterministic-test-order-in-trident-ext-test
Deterministic test order in Trident external test
2022-01-11 12:28:10 +05:30
Kamil Śliwak
10c954fd73
Merge pull request #12512 from ethereum/fix-trident-ext-test-after-preset-selection-pr
Fix preset selection in Trident external test
2022-01-10 22:16:08 +01:00
Kamil Śliwak
cc49eeda3f trident: Note explaining the hard-coded commit 2022-01-10 21:36:58 +01:00
Kamil Śliwak
7142bfa548 trident: Sort test suites to make the order the same in CI and locally 2022-01-10 21:36:58 +01:00
Kamil Śliwak
823f0da3ee trident: Update to match changes done to other external tests in the preset selection PR 2022-01-10 21:28:32 +01:00
Kamil Śliwak
4842774ab8
Merge pull request #12440 from ethereum/preset-selection-in-ext-tests
Preset selection in external tests
2022-01-10 21:15:45 +01:00
Kamil Śliwak
e49cf773b7
Merge pull request #12509 from ethereum/fix-trident-ext-test
Pin Trident external test to a specific commit to work around failing tests on master
2022-01-10 20:40:04 +01:00
Christian Parpart
f5ff358add Adds missing accepts to ImportDirective's SymbolAlias::symbol 2022-01-10 19:32:28 +01:00
Kamil Śliwak
b8b8fcb463 Switch the trident external test to and earlier, working revision 2022-01-10 18:54:50 +01:00
Kamil Śliwak
b60b596741 externalTests: Add support for cloning repos at a specific commit 2022-01-10 18:38:48 +01:00
Daniel Kirchner
e2fe14b0e4
Merge pull request #12510 from ethereum/parallel-run-number-in-gitter-job-notifications
Parallel run number in gitter CI notifcations
2022-01-10 17:07:22 +01:00
Kamil Śliwak
483148ddff Include the parallel run number in gitter notifcations from CI 2022-01-10 16:26:14 +01:00
Harikrishnan Mulackal
c7f6fe2eda
Merge pull request #12197 from ethereum/trident-ext-test
External tests for sushiswap/trident
2022-01-10 19:47:36 +05:30
Kamil Śliwak
1928b7843b externalTests: Preset selection via command-line arguments 2022-01-10 14:44:00 +01:00
Kamil Śliwak
2d038cddff trident ext test: Patch upstream instread of relying on our fork 2022-01-10 14:37:25 +01:00
Kamil Śliwak
6980fa32e2 External test for sushiswap/trident 2022-01-10 14:37:24 +01:00
Kamil Śliwak
19b1a13c6d externalTests: Add support for hardhat.config.ts 2022-01-10 14:37:24 +01:00
Harikrishnan Mulackal
eee30b6ead
Merge pull request #12504 from brien-tech/patch-1
Fixing typo in "smart contracts"
2022-01-10 13:43:23 +05:30
Harikrishnan Mulackal
3731c0f4ac
Merge pull request #12500 from safwen1/patch-1
Explaining payable(msg.sender)
2022-01-10 13:28:56 +05:30
Brien
790e7f42a1
Fixing typo in "smart contracts" 2022-01-10 02:29:51 -05:00
Mohamed Safouen Bouabid
4c20821e6d Explaining payable(msg.sender)
At this point of the documentation a new Solidity learner will not understand this line without further explanation:
if (!payable(msg.sender).send(amount)) {
It should explain how msg.sender is of type "address" and not "address payable" so it cannot send or receive Ether. Therefore it must be explicitly converted to payable.
2022-01-10 12:49:30 +05:30
Harikrishnan Mulackal
c3b4292d1d
Merge pull request #12498 from ethereum/add-function-hoister-to-ese
Add FunctionHoister as a pre-requisite for equal store eliminator.
2022-01-06 20:10:37 +05:30
Bhargava Shastry
2c7aed1d7e Add FunctionHoister as a pre-requisite for equal store eliminator. 2022-01-06 14:16:02 +01:00
Mathias L. Baumann
63b6bbe15c
Merge pull request #12471 from ethereum/modifiers-control-flow-11483
Properly generated control flows for inherited modifiers
2022-01-06 13:39:50 +01:00
Marenz
e969aed780 Properly resolve virtual modifiers 2022-01-06 12:52:06 +01:00
chriseth
e17b06f4fd
Merge pull request #12497 from esquith/develop
Fix typo
2022-01-06 10:36:21 +01:00
Esquith Allen
b1ef5de496 fix typo 2022-01-05 21:58:41 -05:00
Christian Parpart
b6a203a9e8
Merge pull request #12493 from ethereum/lspAssert
LSP: Introduces lspAssert(condition, ErrorCode, message)
2022-01-05 12:18:32 +01:00
Christian Parpart
1bd0f9570f LSP: Introduces lspAssert(condition, ErrorCode, message) 2022-01-05 11:30:04 +01:00
chriseth
c16867cb83
Merge pull request #12272 from ethereum/equalStoreEliminator
Equal store eliminator.
2022-01-05 11:24:59 +01:00
chriseth
679f73c1e0
Merge pull request #12276 from ethereum/fuzz-RSE
Yul interpreter: Changes required before merging Redundant store eliminator
2022-01-05 11:23:51 +01:00
chriseth
02ed2f0054
Merge pull request #12482 from ethereum/lsp-handler-error
LSP: Introduce RequestError exception for easier handling
2022-01-05 11:18:56 +01:00
Christian Parpart
4105b0a587 LSP: Introduce HandlerError(id, code, message) exception for easier handling. 2022-01-05 11:04:40 +01:00
Harikrishnan Mulackal
75df03c8a8
Merge pull request #12490 from fulldecent/develop
Typo: SemVer
2022-01-05 13:32:29 +05:30
William Entriken
c798ac472e Typo: SemVer 2022-01-04 18:59:40 -05:00
chriseth
b892851d7c
Merge pull request #12489 from ethereum/fixPhaserTest
Use fixed seed for flaky phaser test for now.
2022-01-04 18:38:44 +01:00
Daniel Kirchner
671064b609 Use fixed seed for flaky phaser test for now. 2022-01-04 18:27:31 +01:00
Daniel Kirchner
cac0f203a2
Merge pull request #12467 from ethereum/fixMappingExample
Fix mapping example.
2022-01-04 18:23:57 +01:00
chriseth
e3bb5ab7b2
Merge pull request #12431 from ethereum/fixFun2
Safer constructors for FunctionType
2022-01-04 18:18:21 +01:00
Daniel Kirchner
55233285f4
Merge pull request #12480 from ethereum/static_z3_script_impish
Add impish to static Z3 PPA script.
2022-01-04 16:45:12 +01:00
chriseth
6dbe0d0933
Merge pull request #12436 from ethereum/testBatcher
Test batcher.
2022-01-04 16:21:56 +01:00
Bhargava Shastry
b8ad2b2718 Yul interpreter: Add flag to disable memory tracing and dump for fuzzing.
Model revert in yul interpreter.
Add logTrace for a few more instructions and clear trace on revert.
2022-01-04 11:56:27 +01:00
chriseth
13723fe2bf
Merge pull request #12486 from bradenwatling/patch-2
Update control-structures.rst
2022-01-04 11:11:10 +01:00
Braden Watling
bb16c1943c Fix gas retaining statement.
According to https://docs.soliditylang.org/en/v0.8.11/introduction-to-smart-contracts.html?highlight=63%2F64#message-calls, the caller forwards 63/64th of its gas, but here we seem to contradict that by saying the caller retains 63/64th of its gas.
2022-01-04 11:10:31 +01:00
hrkrshnn
85d1a57e65 Added more tests. Updated chromosome. Remove unused headers. 2022-01-04 13:27:39 +05:30
Harikrishnan Mulackal
96f06d29c2
Merge pull request #12485 from bradenwatling/patch-1
Fix typo in control-structures.rst
2022-01-04 11:50:37 +05:30
Braden Watling
6fe1ee6a8a
Fix typo in control-structures.rst
I'm learning Solidity by reading these docs and found this statement confusing. I'm fairly certain that the correct description here is that the *callee* changes get reverted, but the caller is able to react to the failures.

I tested this with the following snippet in Remix, which resulted in a successful transaction when deployed:

```
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.7;

contract A {
    uint public value;

    function a(uint newValue, bool shouldRevert) external {
        value = newValue;
        if (shouldRevert) {
            revert();
        }
    }
}

contract B {
    function b() external {
        A a = new A();
        try a.a(50, false) {
            assert(a.value() == 50);
        } catch {
            assert(false);
        }
        a = new A();
        try a.a(50, true) {
            assert(false);
        } catch {
            assert(a.value() == 0);
        }
    }
}
```
2022-01-03 17:22:23 -05:00
chriseth
c28f85f1e2
Merge pull request #12484 from ethereum/fix-interpreter-mem-overflow-bug
Impose stricter upper bound on memory accesses in order to prevent wrap around
2022-01-03 19:16:09 +01:00
Bhargava Shastry
259a98b82c Impose stricter upper bound on memory accesses in order to prevent overflow/wrap around. 2022-01-03 18:22:42 +01:00