cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Disallows fixed-size multidim. arrays with zero-length.

Browse Source
This commit is contained in:
Erik Kundt 2018-09-21 18:26:19 +02:00
parent 5f919d02ab
commit ff5be17990
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libsolidity/analysis/TypeChecker.cpp
View File

@ -822,12 +822,17 @@ bool TypeChecker::visit(VariableDeclaration const& _variable)
{ {
case Type::Category::Array: case Type::Category::Array:
if (auto arrayType = dynamic_cast<ArrayType const*>(varType.get())) if (auto arrayType = dynamic_cast<ArrayType const*>(varType.get()))
{
if ( if (
((arrayType->location() == DataLocation::Memory) || ((arrayType->location() == DataLocation::Memory) ||
(arrayType->location() == DataLocation::CallData)) && (arrayType->location() == DataLocation::CallData)) &&
!arrayType->validForCalldata() !arrayType->validForCalldata()
) )
m_errorReporter.typeError(_variable.location(), "Array is too large to be encoded."); m_errorReporter.typeError(_variable.location(), "Array is too large to be encoded.");
if (auto baseType = dynamic_cast<ArrayType const*>(arrayType->baseType().get()))
if (!baseType->isDynamicallySized() && baseType->length() == 0)
m_errorReporter.typeError(_variable.location(), "Fixed-size multidimensional arrays are not allowed to have zero length.");
}
break; break;
case Type::Category::Mapping: case Type::Category::Mapping:
if (auto mappingType = dynamic_cast<MappingType const*>(varType.get())) if (auto mappingType = dynamic_cast<MappingType const*>(varType.get()))

6
test/libsolidity/syntaxTests/array/multi_dim_zero_length.sol Normal file
View File

@ -0,0 +1,6 @@
contract C {
bytes[0] a;
function f() public pure returns(bytes32[0][500] memory) {}
}
// ----
// TypeError: (62-84): Fixed-size multidimensional arrays are not allowed to have zero length.