cerc-io/solidity
11
0 Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use fully qualified name of super in message

Browse Source
This commit is contained in:
Federico Bond authored and Alex Beregszaszi committed 2017-08-11 22:45:25 +01:00
1 parent a5ceaac8df
commit ff5bb54e3c
3 files changed
+13 -4
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

libsolidity/analysis/TypeChecker.cpp
+3 -4
View File
@@ -1950,13 +1950,12 @@ void TypeChecker::requireLValue(Expression const& _expression)
m_errorReporter.typeError(_expression.location(), "Expression has to be an lvalue.");
}
void TypeChecker::overrideTypeError(FunctionDefinition const& function, FunctionDefinition const& super)
{
string message;
if (function.visibility() != super.visibility())
message = "Overriding function visibility differs from extended function.";
message = "Overriding function visibility differs from " + super.fullyQualifiedName() + ".";
else if (function.isDeclaredConst() && !super.isDeclaredConst())
message = "Overriding function should not be declared constant.";
else if (!function.isDeclaredConst() && super.isDeclaredConst())
@@ -1972,11 +1971,11 @@ void TypeChecker::overrideTypeError(FunctionDefinition const& function, Function
FunctionType superType(super);
if (functionType != superType)
message = "Overriding function return types differ from extended function.";
message = "Overriding function return types differ from " + super.fullyQualifiedName() + ".";
}
if (message.empty())
message = "Override changes extended function signature.";
message = "Overriding function signature differs from " + super.fullyQualifiedName() + ".";
m_errorReporter.typeError(function.location(), message);
}