cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Review suggestions

Browse Source
This commit is contained in:
Leonardo Alt 2018-08-15 16:58:41 +02:00
parent c3d3ae80fa
commit faed71c6b1
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libsolidity/analysis/TypeChecker.cpp
View File

@ -898,12 +898,12 @@ bool TypeChecker::visit(EventDefinition const& _eventDef)
{ {
numIndexed++; numIndexed++;
if ( if (
_eventDef.sourceUnit().annotation().experimentalFeatures.count(ExperimentalFeature::ABIEncoderV2) _eventDef.sourceUnit().annotation().experimentalFeatures.count(ExperimentalFeature::ABIEncoderV2) &&
&& dynamic_cast<ReferenceType const*>(type(*var).get()) dynamic_cast<ReferenceType const*>(type(*var).get())
) )
m_errorReporter.typeError( m_errorReporter.typeError(
var->location(), var->location(),
"Reference types cannot be indexed." "Indexed reference types cannot yet be used with ABIEncoderV2."
); );
} }
if (!type(*var)->canLiveOutsideStorage()) if (!type(*var)->canLiveOutsideStorage())

2
test/libsolidity/syntaxTests/events/event_array_indexed_v2.sol
View File

@ -4,4 +4,4 @@ contract c {
} }
// ---- // ----
// Warning: (0-33): Experimental features are turned on. Do not use experimental features on live deployments. // Warning: (0-33): Experimental features are turned on. Do not use experimental features on live deployments.
// TypeError: (59-65): Reference types cannot be indexed. // TypeError: (59-65): Indexed reference types cannot yet be used with ABIEncoderV2.

2
test/libsolidity/syntaxTests/events/event_nested_array_indexed_v2.sol
View File

@ -4,4 +4,4 @@ contract c {
} }
// ---- // ----
// Warning: (0-33): Experimental features are turned on. Do not use experimental features on live deployments. // Warning: (0-33): Experimental features are turned on. Do not use experimental features on live deployments.
// TypeError: (59-67): Reference types cannot be indexed. // TypeError: (59-67): Indexed reference types cannot yet be used with ABIEncoderV2.

2
test/libsolidity/syntaxTests/events/event_struct_indexed_v2.sol
View File

@ -5,4 +5,4 @@ contract c {
} }
// ---- // ----
// Warning: (0-33): Experimental features are turned on. Do not use experimental features on live deployments. // Warning: (0-33): Experimental features are turned on. Do not use experimental features on live deployments.
// TypeError: (85-86): Reference types cannot be indexed. // TypeError: (85-86): Indexed reference types cannot yet be used with ABIEncoderV2.