cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Makes visibility warning more concise.

Browse Source
This commit is contained in:
Erik Kundt 2018-03-28 18:10:32 +02:00
parent 601659c384
commit f9efa41749
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libsolidity/analysis/StaticAnalyzer.cpp
View File

@ -51,12 +51,14 @@ void StaticAnalyzer::endVisit(ContractDefinition const&)
bool StaticAnalyzer::visit(FunctionDefinition const& _function) bool StaticAnalyzer::visit(FunctionDefinition const& _function)
{ {
const bool isInterface = m_currentContract->contractKind() == ContractDefinition::ContractKind::Interface; const bool isInterface = m_currentContract->contractKind() == ContractDefinition::ContractKind::Interface;
if (_function.noVisibilitySpecified()) if (_function.noVisibilitySpecified())
m_errorReporter.warning( m_errorReporter.warning(
_function.location(), _function.location(),
"No visibility specified. Defaulting to \"" + "No visibility specified. Defaulting to \"" +
(isInterface ? "external" : Declaration::visibilityToString(_function.visibility())) + Declaration::visibilityToString(_function.visibility()) +
"\"." "\". " +
(isInterface ? "In interfaces it defaults to external." : "")
); );
if (_function.isImplemented()) if (_function.isImplemented())
m_currentFunction = &_function; m_currentFunction = &_function;

2
test/libsolidity/syntaxTests/visibility/interface/function_default.sol
View File

@ -3,4 +3,4 @@ interface I {
} }
// ---- // ----
// Warning: Functions in interfaces should be declared external. // Warning: Functions in interfaces should be declared external.
// Warning: No visibility specified. Defaulting to "external". // Warning: No visibility specified. Defaulting to "public". In interfaces it defaults to external.