From ee09d545252e50b36f865da8e70cb46e3e21b219 Mon Sep 17 00:00:00 2001 From: Alex Beregszaszi Date: Tue, 29 Jan 2019 00:35:23 +0000 Subject: [PATCH] Change FIXMEs into TODOs where appropriate --- libsolidity/ast/Types.cpp | 4 ++-- libsolidity/interface/CompilerStack.cpp | 4 ++-- libyul/optimiser/InlinableExpressionFunctionFinder.cpp | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libsolidity/ast/Types.cpp b/libsolidity/ast/Types.cpp index 691579042..308c0fe5e 100644 --- a/libsolidity/ast/Types.cpp +++ b/libsolidity/ast/Types.cpp @@ -3027,8 +3027,8 @@ u256 FunctionType::externalIdentifier() const bool FunctionType::isPure() const { - // FIXME: replace this with m_stateMutability == StateMutability::Pure once - // the callgraph analyzer is in place + // TODO: replace this with m_stateMutability == StateMutability::Pure once + // the callgraph analyzer is in place return m_kind == Kind::KECCAK256 || m_kind == Kind::ECRecover || diff --git a/libsolidity/interface/CompilerStack.cpp b/libsolidity/interface/CompilerStack.cpp index 0c140887c..b97e064e8 100644 --- a/libsolidity/interface/CompilerStack.cpp +++ b/libsolidity/interface/CompilerStack.cpp @@ -473,7 +473,7 @@ eth::LinkerObject const& CompilerStack::runtimeObject(string const& _contractNam return contract(_contractName).runtimeObject; } -/// FIXME: cache this string +/// TODO: cache this string string CompilerStack::assemblyString(string const& _contractName, StringMap _sourceCodes) const { if (m_stackState != CompilationSuccessful) @@ -486,7 +486,7 @@ string CompilerStack::assemblyString(string const& _contractName, StringMap _sou return string(); } -/// FIXME: cache the JSON +/// TODO: cache the JSON Json::Value CompilerStack::assemblyJSON(string const& _contractName, StringMap _sourceCodes) const { if (m_stackState != CompilationSuccessful) diff --git a/libyul/optimiser/InlinableExpressionFunctionFinder.cpp b/libyul/optimiser/InlinableExpressionFunctionFinder.cpp index f57faa7c2..f72e5357c 100644 --- a/libyul/optimiser/InlinableExpressionFunctionFinder.cpp +++ b/libyul/optimiser/InlinableExpressionFunctionFinder.cpp @@ -50,7 +50,7 @@ void InlinableExpressionFunctionFinder::operator()(FunctionDefinition const& _fu Assignment const& assignment = boost::get(bodyStatement); if (assignment.variableNames.size() == 1 && assignment.variableNames.front().name == retVariable) { - // FIXME: use code size metric here + // TODO: use code size metric here // We cannot overwrite previous settings, because this function definition // would not be valid here if we were searching inside a functionally inlinable