Use proper type in conditional simplifier.

libyul/optimiser/ConditionalSimplifier.cpp

@@ -79,9 +79,9 @@ void ConditionalSimplifier::operator()(Block& _block)
 							{Identifier{location, condition}},
 							make_unique<Expression>(Literal{
 								location,
-								LiteralKind::Number,
+								LiteralKind::Boolean,
-								"0"_yulstring,
+								"false"_yulstring,
-								{}
+								m_dialect.boolType
 							})
 						}
 					);

test/libyul/yulOptimizerTests/conditionalSimplifier/add_correct_type.yul

@@ -0,0 +1,18 @@
+{
+    let y:bool := false
+    for {} true { } {
+        if y { break }
+    }
+}
+// ====
+// dialect: yul
+// step: conditionalSimplifier
+// ----
+// {
+//     let y:bool := false
+//     for { } true { }
+//     {
+//         if y { break }
+//         y := false
+//     }
+// }

test/libyul/yulOptimizerTests/conditionalSimplifier/add_correct_type_wasm.yul

@@ -0,0 +1,18 @@
+{
+    let y:i32 := 0:i32
+    for {} true { } {
+        if y { break }
+    }
+}
+// ====
+// dialect: ewasm
+// step: conditionalSimplifier
+// ----
+// {
+//     let y:i32 := 0:i32
+//     for { } true { }
+//     {
+//         if y { break }
+//         y := false
+//     }
+// }

test/libyul/yulOptimizerTests/conditionalSimplifier/clear_after_if_break.yul

@@ -12,6 +12,6 @@
 //     for { } and(y, 8) { pop(y) }
 //     {
 //         if y { break }
-//         y := 0
+//         y := false
 //     }
 // }

test/libyul/yulOptimizerTests/conditionalSimplifier/clear_after_if_continue.yul

@@ -12,6 +12,6 @@
 //     for { } and(y, 8) { pop(y) }
 //     {
 //         if y { continue }
-//         y := 0
+//         y := false
 //     }
 // }

test/libyul/yulOptimizerTests/conditionalSimplifier/clear_before_for_condition.yul

@@ -14,9 +14,9 @@
 //     let x := mload(0)
 //     let y := mload(0)
 //     if x { revert(0, 0) }
-//     x := 0
+//     x := false
 //     if y { revert(0, 0) }
-//     y := 0
+//     y := false
 //     for { } and(x, y) { }
 //     { x := 2 }
 // }

test/libyul/yulOptimizerTests/conditionalSimplifier/clear_before_for_post.yul

@@ -16,7 +16,7 @@
 //     for { } x { sstore(1, x) }
 //     {
 //         if x { continue }
-//         x := 0
+//         x := false
 //         sstore(0, x)
 //     }
 //     sstore(0, x)

test/libyul/yulOptimizerTests/conditionalSimplifier/no_opt_if_break_is_not_last.yul

@@ -26,7 +26,7 @@
 //             sstore(7, 8)
 //             break
 //         }
-//         x := 0
+//         x := false
 //         sstore(10, x)
 //     }
 // }

test/libyul/yulOptimizerTests/conditionalSimplifier/opt_after_terminating_if.yul

@@ -13,6 +13,6 @@
 //         sstore(0, x)
 //         revert(0, 0)
 //     }
-//     x := 0
+//     x := false
 //     sstore(1, x)
 // }

test/libyul/yulOptimizerTests/fullSuite/clear_after_if_continue.yul

@@ -24,7 +24,7 @@
 //         }
 //         {
 //             if y { continue }
-//             sstore(1, 0)
+//             sstore(1, false)
 //         }
 //         if y { revert(0, 0) }
 //     }