cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Still allow empty structs for non-0.5.0 mode

Browse Source
This commit is contained in:
Alex Beregszaszi 2018-03-27 15:00:33 +01:00
parent b540ba527a
commit ebb12756ad
4 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Changelog.md
View File

@ -3,6 +3,7 @@
Features: Features:
* General: Support accessing dynamic return data in post-byzantium EVMs. * General: Support accessing dynamic return data in post-byzantium EVMs.
* Interfaces: Allow overriding external functions in interfaces with public in an implementing contract. * Interfaces: Allow overriding external functions in interfaces with public in an implementing contract.
* Syntax Checker: Issue warning for empty structs (or error as experimental 0.5.0 feature).
Bugfixes: Bugfixes:
* Code Generator: Allow ``block.blockhash`` without being called. * Code Generator: Allow ``block.blockhash`` without being called.
@ -12,7 +13,6 @@ Bugfixes:
* Commandline interface: Support ``--evm-version constantinople`` properly. * Commandline interface: Support ``--evm-version constantinople`` properly.
* DocString Parser: Fix error message for empty descriptions. * DocString Parser: Fix error message for empty descriptions.
* Standard JSON: Support ``constantinople`` as ``evmVersion`` properly. * Standard JSON: Support ``constantinople`` as ``evmVersion`` properly.
* Syntax Checker: Issue error for empty structs.
* Type System: Make external library functions accessible. * Type System: Make external library functions accessible.
### 0.4.21 (2018-03-07) ### 0.4.21 (2018-03-07)

9
libsolidity/analysis/SyntaxChecker.cpp
View File

@ -258,7 +258,14 @@ bool SyntaxChecker::visit(VariableDeclaration const& _declaration)
bool SyntaxChecker::visit(StructDefinition const& _struct) bool SyntaxChecker::visit(StructDefinition const& _struct)
{ {
bool const v050 = m_sourceUnit->annotation().experimentalFeatures.count(ExperimentalFeature::V050);
if (_struct.members().empty()) if (_struct.members().empty())
m_errorReporter.syntaxError(_struct.location(), "Defining empty structs is disallowed."); {
if (v050)
m_errorReporter.syntaxError(_struct.location(), "Defining empty structs is disallowed.");
else
m_errorReporter.warning(_struct.location(), "Defining empty structs is deprecated.");
}
return true; return true;
} }

2
test/libsolidity/syntaxTests/empty_struct.sol
View File

@ -2,4 +2,4 @@ contract test {
struct A {} struct A {}
} }
// ---- // ----
// SyntaxError: Defining empty structs is disallowed. // Warning: Defining empty structs is deprecated.

6
test/libsolidity/syntaxTests/empty_struct_050.sol Normal file
View File

@ -0,0 +1,6 @@
pragma experimental "v0.5.0";
contract test {
struct A {}
}
// ----
// SyntaxError: Defining empty structs is disallowed.