From eaadc71b4c88603a7264211401d249ca1ead22e3 Mon Sep 17 00:00:00 2001
From: Lefteris Karapetsas <lefteris@refu.co>
Date: Thu, 5 Feb 2015 13:48:02 +0100
Subject: [PATCH] Tests and fixes for ether subdenominations

---
 Parser.cpp |  4 ++--
 Types.cpp  | 31 ++++++++++++++++---------------
 2 files changed, 18 insertions(+), 17 deletions(-)

diff --git a/Parser.cpp b/Parser.cpp
index 6449ba93d..741b9aba7 100644
--- a/Parser.cpp
+++ b/Parser.cpp
@@ -694,10 +694,10 @@ ASTPointer<Expression> Parser::parsePrimaryExpression()
 	case Token::NUMBER:
 		nextToken = m_scanner->peekNextToken();
 	case Token::STRING_LITERAL:
-		if (Token::isEtherSubdenomination(nextToken))
-			m_scanner->next();
 		nodeFactory.markEndPosition();
 		expression = nodeFactory.createNode<Literal>(token, getLiteralAndAdvance(), nextToken);
+		if (Token::isEtherSubdenomination(nextToken))
+			m_scanner->next();
 		break;
 	case Token::IDENTIFIER:
 		nodeFactory.markEndPosition();
diff --git a/Types.cpp b/Types.cpp
index 98c648025..c554f3551 100644
--- a/Types.cpp
+++ b/Types.cpp
@@ -328,31 +328,32 @@ string IntegerConstantType::toString() const
 
 u256 IntegerConstantType::literalValue(Literal const* _literal) const
 {
-	Literal::ethSubDenomination sub =_literal->getSubDenomination();
 	u256 value;
 	// we ignore the literal and hope that the type was correctly determined
 	solAssert(m_value <= u256(-1), "Integer constant too large.");
 	solAssert(m_value >= -(bigint(1) << 255), "Integer constant too small.");
 
-
 	if (m_value >= 0)
 		value = u256(m_value);
 	else
 		value = s2u(s256(m_value));
 
-	switch(sub) {
-	case Literal::ethSubDenomination::WEI:
-	case Literal::ethSubDenomination::NONE:
-		break;
-	case Literal::ethSubDenomination::SZABO:
-		value *= u256(1000000000000);
-		break;
-	case Literal::ethSubDenomination::FINNEY:
-		value *= u256(1000000000000000);
-		break;
-	case Literal::ethSubDenomination::ETHER:
-		value *= u256(1000000000000000000);
-		break;
+	if (_literal) {
+		Literal::ethSubDenomination sub =_literal->getSubDenomination();
+		switch(sub) {
+		case Literal::ethSubDenomination::WEI:
+		case Literal::ethSubDenomination::NONE:
+			break;
+		case Literal::ethSubDenomination::SZABO:
+			value *= u256(1000000000000);
+			break;
+		case Literal::ethSubDenomination::FINNEY:
+			value *= u256(1000000000000000);
+			break;
+		case Literal::ethSubDenomination::ETHER:
+			value *= u256(1000000000000000000);
+			break;
+		}
 	}
 
 	return value;