cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

parser: recognize an end of comment of the form **/ at the end of a multi-line doc comment

Browse Source 
This fixes #1433
This commit is contained in:
Yoichi Hirai 2016-11-30 17:28:07 +01:00
parent ac357d1225
commit eaab712944
No known key found for this signature in database
GPG Key ID: E7B75D080FCF7992
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libsolidity/parsing/Scanner.cpp
View File

@ -327,7 +327,12 @@ Token::Value Scanner::scanMultiLineDocComment()
if (isLineTerminator(m_char)) if (isLineTerminator(m_char))
{ {
skipWhitespace(); skipWhitespace();
if (!m_source.isPastEndOfInput(1) && m_source.get(0) == '*' && m_source.get(1) != '/') if (!m_source.isPastEndOfInput(1) && m_source.get(0) == '*' && m_source.get(1) == '*')
{ // it is unknown if this leads to the end of the comment
addCommentLiteralChar('*');
advance();
}
else if (!m_source.isPastEndOfInput(1) && m_source.get(0) == '*' && m_source.get(1) != '/')
{ // skip first '*' in subsequent lines { // skip first '*' in subsequent lines
if (charsAdded) if (charsAdded)
addCommentLiteralChar('\n'); addCommentLiteralChar('\n');

13
test/libsolidity/SolidityParser.cpp
View File

@ -962,6 +962,19 @@ BOOST_AUTO_TEST_CASE(empty_comment)
BOOST_CHECK(successParse(text)); BOOST_CHECK(successParse(text));
} }
BOOST_AUTO_TEST_CASE(comment_end_with_double_star)
{
char const* text = R"(
contract C1 {
/**
**/
}
contract C2 {}
)";
BOOST_CHECK(successParse(text));
}
BOOST_AUTO_TEST_CASE(library_simple) BOOST_AUTO_TEST_CASE(library_simple)
{ {
char const* text = R"( char const* text = R"(