cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #9411 from ethereum/private-payable-msg

Browse Source 
Nicer error message for private payable functions
This commit is contained in:
chriseth 2020-07-14 15:55:13 +02:00 committed by GitHub
commit e970e58a9f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libsolidity/analysis/TypeChecker.cpp
View File

@ -337,7 +337,7 @@ bool TypeChecker::visit(FunctionDefinition const& _function)
if (_function.libraryFunction()) if (_function.libraryFunction())
m_errorReporter.typeError(7708_error, _function.location(), "Library functions cannot be payable."); m_errorReporter.typeError(7708_error, _function.location(), "Library functions cannot be payable.");
if (_function.isOrdinary() && !_function.isPartOfExternalInterface()) if (_function.isOrdinary() && !_function.isPartOfExternalInterface())
m_errorReporter.typeError(5587_error, _function.location(), "Internal functions cannot be payable."); m_errorReporter.typeError(5587_error, _function.location(), "\"internal\" and \"private\" functions cannot be payable.");
} }
auto checkArgumentAndReturnParameter = [&](VariableDeclaration const& var) { auto checkArgumentAndReturnParameter = [&](VariableDeclaration const& var) {
if (type(var)->category() == Type::Category::Mapping) if (type(var)->category() == Type::Category::Mapping)

2
test/libsolidity/syntaxTests/nameAndTypeResolution/356_payable_internal.sol
View File

@ -2,4 +2,4 @@ contract test {
function f() payable internal {} function f() payable internal {}
} }
// ---- // ----
// TypeError 5587: (20-52): Internal functions cannot be payable. // TypeError 5587: (20-52): "internal" and "private" functions cannot be payable.

2
test/libsolidity/syntaxTests/nameAndTypeResolution/357_payable_private.sol
View File

@ -2,4 +2,4 @@ contract test {
function f() payable private {} function f() payable private {}
} }
// ---- // ----
// TypeError 5587: (20-51): Internal functions cannot be payable. // TypeError 5587: (20-51): "internal" and "private" functions cannot be payable.