cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #6612 from ethereum/abi-functions-assertion

Browse Source 
Unifies behaviour for member access of ABI functions
This commit is contained in:
chriseth 2019-04-29 15:02:40 +02:00 committed by GitHub
commit e8ba10bfaa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libsolidity/codegen/ExpressionCompiler.cpp
View File

@ -1401,7 +1401,7 @@ bool ExpressionCompiler::visit(MemberAccess const& _memberAccess)
m_context << Instruction::DUP1 << u256(32) << Instruction::ADD; m_context << Instruction::DUP1 << u256(32) << Instruction::ADD;
utils().storeStringData(contract.name()); utils().storeStringData(contract.name());
} }
else if (member == "encode" || member == "decode") else if ((set<string>{"encode", "encodePacked", "encodeWithSelector", "encodeWithSignature", "decode"}).count(member))
{ {
// no-op // no-op
} }

3
test/libsolidity/semanticTests/specialFunctions/abi_encode_decode_member_access.sol → test/libsolidity/semanticTests/specialFunctions/abi_functions_member_access.sol
View File

@ -1,6 +1,9 @@
contract C { contract C {
function f() public pure { function f() public pure {
abi.encode; abi.encode;
abi.encodePacked;
abi.encodeWithSelector;
abi.encodeWithSignature;
abi.decode; abi.decode;
} }
} }

15
test/libsolidity/syntaxTests/specialFunctions/abi_functions_member_access.sol Normal file
View File

@ -0,0 +1,15 @@
contract C {
function f() public pure {
abi.encode;
abi.encodePacked;
abi.encodeWithSelector;
abi.encodeWithSignature;
abi.decode;
}
}
// ----
// Warning: (52-62): Statement has no effect.
// Warning: (72-88): Statement has no effect.
// Warning: (98-120): Statement has no effect.
// Warning: (130-153): Statement has no effect.
// Warning: (163-173): Statement has no effect.