cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Detect custom type expressions that have no effect

Browse Source
This commit is contained in:
Mathias Baumann 2019-02-18 18:19:55 +01:00
parent ee9394b4aa
commit e3d4155fa8
5 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changelog.md
View File

@ -4,6 +4,7 @@ Language Features:
Compiler Features:
* Static Analyzer: Warn about expressions with custom types when they have no effect.
Bugfixes:

5
libsolidity/analysis/TypeChecker.cpp
View File

@ -2316,8 +2316,13 @@ bool TypeChecker::visit(Identifier const& _identifier)
if (auto variableDeclaration = dynamic_cast<VariableDeclaration const*>(annotation.referencedDeclaration))
annotation.isPure = annotation.isConstant = variableDeclaration->isConstant();
else if (dynamic_cast<MagicVariableDeclaration const*>(annotation.referencedDeclaration))
{
if (dynamic_cast<FunctionType const*>(annotation.type.get()))
annotation.isPure = true;
}
else if (dynamic_cast<TypeType const*>(annotation.type.get()))
annotation.isPure = true;
// Check for deprecated function names.
// The check is done here for the case without an actual function call.

1
test/libsolidity/syntaxTests/metaTypes/typeOfContract.sol
View File

@ -4,3 +4,4 @@ contract Test {
}
}
// ----
// Warning: (78-88): Statement has no effect.

2
test/libsolidity/syntaxTests/nameAndTypeResolution/001_name_references.sol
View File

@ -2,3 +2,5 @@ contract test {
uint256 variable;
function f(uint256) public returns (uint out) { f(variable); test; out; }
}
// ----
// Warning: (103-107): Statement has no effect.

16
test/libsolidity/syntaxTests/nameAndTypeResolution/no_effect_statements.sol Normal file
View File

@ -0,0 +1,16 @@
contract test {
struct s { uint a; uint b;}
function f() pure public returns (byte) {
s;
s(1,2);
s[7];
uint;
uint[7];
}
}
// ----
// Warning: (93-94): Statement has no effect.
// Warning: (98-104): Statement has no effect.
// Warning: (108-112): Statement has no effect.
// Warning: (116-120): Statement has no effect.
// Warning: (124-131): Statement has no effect.