cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Suggests external for fallback and interface functions.

Browse Source
This commit is contained in:
chriseth 2018-07-10 22:43:02 +02:00 committed by Erik Kundt
parent 75bba5c9f0
commit dfd2fee91d
9 changed files with 31 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
libsolidity/analysis/SyntaxChecker.cpp
View File

@ -197,12 +197,24 @@ bool SyntaxChecker::visit(PlaceholderStatement const&)
return true; return true;
} }
bool SyntaxChecker::visit(ContractDefinition const& _contract)
{
m_isInterface = _contract.contractKind() == ContractDefinition::ContractKind::Interface;
return true;
}
bool SyntaxChecker::visit(FunctionDefinition const& _function) bool SyntaxChecker::visit(FunctionDefinition const& _function)
{ {
bool const v050 = m_sourceUnit->annotation().experimentalFeatures.count(ExperimentalFeature::V050); bool const v050 = m_sourceUnit->annotation().experimentalFeatures.count(ExperimentalFeature::V050);
if (_function.noVisibilitySpecified()) if (_function.noVisibilitySpecified())
m_errorReporter.syntaxError(_function.location(), "No visibility specified."); {
string suggestedVisibility = _function.isFallback() || m_isInterface ? "external" : "public";
m_errorReporter.syntaxError(
_function.location(),
"No visibility specified. Did you intend to add \"" + suggestedVisibility + "\"?"
);
}
if (_function.isOldStyleConstructor()) if (_function.isOldStyleConstructor())
{ {

2
libsolidity/analysis/SyntaxChecker.h
View File

@ -66,6 +66,7 @@ private:
virtual bool visit(PlaceholderStatement const& _placeholderStatement) override; virtual bool visit(PlaceholderStatement const& _placeholderStatement) override;
virtual bool visit(ContractDefinition const& _contract) override;
virtual bool visit(FunctionDefinition const& _function) override; virtual bool visit(FunctionDefinition const& _function) override;
virtual bool visit(FunctionTypeName const& _node) override; virtual bool visit(FunctionTypeName const& _node) override;
@ -82,6 +83,7 @@ private:
bool m_versionPragmaFound = false; bool m_versionPragmaFound = false;
int m_inLoopDepth = 0; int m_inLoopDepth = 0;
bool m_isInterface = false;
SourceUnit const* m_sourceUnit = nullptr; SourceUnit const* m_sourceUnit = nullptr;
}; };

2
test/libsolidity/syntaxTests/constructor/constructor_no_visibility.sol
View File

@ -1,3 +1,3 @@
contract A { constructor() {} } contract A { constructor() {} }
// ---- // ----
// SyntaxError: (13-29): No visibility specified. // SyntaxError: (13-29): No visibility specified. Did you intend to add "public"?

2
test/libsolidity/syntaxTests/constructor/constructor_no_visibility_050.sol
View File

@ -1,4 +1,4 @@
pragma experimental "v0.5.0"; pragma experimental "v0.5.0";
contract A { constructor() {} } contract A { constructor() {} }
// ---- // ----
// SyntaxError: (43-59): No visibility specified. // SyntaxError: (43-59): No visibility specified. Did you intend to add "public"?

2
test/libsolidity/syntaxTests/fallback/default_visibility.sol
View File

@ -3,5 +3,5 @@ contract C {
function() {} function() {}
} }
// ---- // ----
// SyntaxError: (90-103): No visibility specified. // SyntaxError: (90-103): No visibility specified. Did you intend to add "external"?
// TypeError: (90-103): Fallback function must be defined as "external". // TypeError: (90-103): Fallback function must be defined as "external".

2
test/libsolidity/syntaxTests/nameAndTypeResolution/567_require_visibility_specifiers_v050.sol
View File

@ -3,4 +3,4 @@ contract C {
function f() pure { } function f() pure { }
} }
// ---- // ----
// SyntaxError: (47-68): No visibility specified. // SyntaxError: (47-68): No visibility specified. Did you intend to add "public"?

2
test/libsolidity/syntaxTests/visibility/function_no_visibility.sol
View File

@ -2,4 +2,4 @@ contract C {
function f() pure { } function f() pure { }
} }
// ---- // ----
// SyntaxError: (17-38): No visibility specified. // SyntaxError: (17-38): No visibility specified. Did you intend to add "public"?

2
test/libsolidity/syntaxTests/visibility/interface/function_default.sol
View File

@ -2,5 +2,5 @@ interface I {
function f(); function f();
} }
// ---- // ----
// SyntaxError: (15-28): No visibility specified. Did you intend to add "public"? // SyntaxError: (15-28): No visibility specified. Did you intend to add "external"?
// TypeError: (15-28): Functions in interfaces must be declared external. // TypeError: (15-28): Functions in interfaces must be declared external.

10
test/libsolidity/syntaxTests/visibility/interface/interface_contract_function_default.sol Normal file
View File

@ -0,0 +1,10 @@
interface I {
function f();
}
contract C {
function g();
}
// ----
// SyntaxError: (18-31): No visibility specified. Did you intend to add "external"?
// SyntaxError: (51-64): No visibility specified. Did you intend to add "public"?
// TypeError: (18-31): Functions in interfaces must be declared external.