From ded5d721d2c97170905a536b1f996b79045c84d1 Mon Sep 17 00:00:00 2001 From: Alex Beregszaszi Date: Mon, 15 Feb 2021 20:28:38 +0000 Subject: [PATCH] Turn unreachable error into assertion --- libyul/AsmAnalysis.cpp | 9 +++++---- scripts/error_codes.py | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/libyul/AsmAnalysis.cpp b/libyul/AsmAnalysis.cpp index 7e8f7ea57..75428fe5b 100644 --- a/libyul/AsmAnalysis.cpp +++ b/libyul/AsmAnalysis.cpp @@ -530,10 +530,11 @@ void AsmAnalyzer::checkAssignment(Identifier const& _variable, YulString _valueT bool found = false; if (Scope::Identifier const* var = m_currentScope->lookup(_variable.name)) { - // Check that it is a variable - if (!holds_alternative(*var)) - m_errorReporter.typeError(2657_error, _variable.location, "Assignment requires variable."); - else if (!m_activeVariables.count(&std::get(*var))) + // Check that it is a variable. + // This can also hold a function, but that is caught by error 6041. + yulAssert(holds_alternative(*var), "Assignment requires variable."); + + if (!m_activeVariables.count(&std::get(*var))) m_errorReporter.declarationError( 1133_error, _variable.location, diff --git a/scripts/error_codes.py b/scripts/error_codes.py index e0e7efad2..95e74e513 100755 --- a/scripts/error_codes.py +++ b/scripts/error_codes.py @@ -221,7 +221,7 @@ def examine_id_coverage(top_dir, source_id_to_file_names, new_ids_only=False): old_source_only_ids = { "1584", "1823", - "1988", "2066", "2657", "2800", "3356", + "1988", "2066", "2800", "3356", "3893", "3996", "4010", "4802", "5073", "5272", "5622", "7128", "7589", "7593", "8065", "8084", "8140",