Merge pull request #1443 from ethereum/unimplemented

Use solUnimplemented wherever possible
This commit is contained in:
chriseth 2016-11-28 14:09:01 +01:00 committed by GitHub
commit dadb4818ba
2 changed files with 3 additions and 3 deletions

View File

@ -200,7 +200,7 @@ void ArrayUtils::copyArrayToStorage(ArrayType const& _targetType, ArrayType cons
else if (sourceBaseType->isValueType()) else if (sourceBaseType->isValueType())
CompilerUtils(m_context).loadFromMemoryDynamic(*sourceBaseType, fromCalldata, true, false); CompilerUtils(m_context).loadFromMemoryDynamic(*sourceBaseType, fromCalldata, true, false);
else else
solAssert(false, "Copying of type " + _sourceType.toString(false) + " to storage not yet supported."); solUnimplemented("Copying of type " + _sourceType.toString(false) + " to storage not yet supported.");
// stack: target_ref target_data_end source_data_pos target_data_pos source_data_end [target_byte_offset] [source_byte_offset] <source_value>... // stack: target_ref target_data_end source_data_pos target_data_pos source_data_end [target_byte_offset] [source_byte_offset] <source_value>...
solAssert( solAssert(
2 + byteOffsetSize + sourceBaseType->sizeOnStack() <= 16, 2 + byteOffsetSize + sourceBaseType->sizeOnStack() <= 16,

View File

@ -1252,7 +1252,7 @@ void ExpressionCompiler::endVisit(Literal const& _literal)
case Type::Category::StringLiteral: case Type::Category::StringLiteral:
break; // will be done during conversion break; // will be done during conversion
default: default:
BOOST_THROW_EXCEPTION(InternalCompilerError() << errinfo_comment("Only integer, boolean and string literals implemented for now.")); solUnimplemented("Only integer, boolean and string literals implemented for now.");
} }
} }
@ -1392,7 +1392,7 @@ void ExpressionCompiler::appendBitOperatorCode(Token::Value _operator)
void ExpressionCompiler::appendShiftOperatorCode(Token::Value _operator) void ExpressionCompiler::appendShiftOperatorCode(Token::Value _operator)
{ {
BOOST_THROW_EXCEPTION(UnimplementedFeatureError() << errinfo_comment("Shift operators not yet implemented.")); solUnimplemented("Shift operators not yet implemented.");
switch (_operator) switch (_operator)
{ {
case Token::SHL: case Token::SHL: