cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #4352 from D-Nice/develop

Browse Source 
Fixes storage ref var typo error from 'prefix' to 'suffix'
This commit is contained in:
chriseth 2018-06-29 12:27:29 +02:00 committed by GitHub
commit d469df45d8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libsolidity/analysis/TypeChecker.cpp
View File

@ -929,7 +929,7 @@ bool TypeChecker::visit(InlineAssembly const& _inlineAssembly)
} }
else if (var->type()->dataStoredIn(DataLocation::Storage)) else if (var->type()->dataStoredIn(DataLocation::Storage))
{ {
m_errorReporter.typeError(_identifier.location, "You have to use the _slot or _offset prefix to access storage reference variables."); m_errorReporter.typeError(_identifier.location, "You have to use the _slot or _offset suffix to access storage reference variables.");
return size_t(-1); return size_t(-1);
} }
else if (var->type()->sizeOnStack() != 1) else if (var->type()->sizeOnStack() != 1)

11
test/libsolidity/syntaxTests/inlineAssembly/storage_reference.sol Normal file
View File

@ -0,0 +1,11 @@
contract C {
uint[] x;
function() public {
uint[] storage y = x;
assembly {
pop(y)
}
}
}
// ----
// TypeError: (117-118): You have to use the _slot or _offset suffix to access storage reference variables.

11
test/libsolidity/syntaxTests/inlineAssembly/storage_reference_fine.sol Normal file
View File

@ -0,0 +1,11 @@
contract C {
uint[] x;
function() public {
uint[] storage y = x;
assembly {
pop(y_slot)
pop(y_offset)
}
}
}
// ----