cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

No need to visit structs early.

Browse Source
This commit is contained in:
chriseth 2018-11-29 18:18:17 +01:00
parent 621ce3df20
commit d1cc731843
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libsolidity/analysis/TypeChecker.cpp
View File

@ -88,11 +88,6 @@ bool TypeChecker::visit(ContractDefinition const& _contract)
{ {
m_scope = &_contract; m_scope = &_contract;
// We force our own visiting order here. The structs have to be excluded below.
set<ASTNode const*> visited;
for (auto const& s: _contract.definedStructs())
visited.insert(s);
ASTNode::listAccept(_contract.definedStructs(), *this);
ASTNode::listAccept(_contract.baseContracts(), *this); ASTNode::listAccept(_contract.baseContracts(), *this);
FunctionDefinition const* function = _contract.constructor(); FunctionDefinition const* function = _contract.constructor();
@ -132,8 +127,7 @@ bool TypeChecker::visit(ContractDefinition const& _contract)
} }
for (auto const& n: _contract.subNodes()) for (auto const& n: _contract.subNodes())
if (!visited.count(n.get())) n->accept(*this);
n->accept(*this);
checkContractExternalTypeClashes(_contract); checkContractExternalTypeClashes(_contract);
// check for hash collisions in function signatures // check for hash collisions in function signatures