Merge pull request #7700 from ethereum/fix-7698

Upgrade evmone to v0.2.0 and adapt fuzzer build
2023-10-03 13:03:40 +00:00 · 2019-11-18 23:05:57 +01:00 · 2019-11-18 23:05:57 +01:00 · cf13339ad8
commit cf13339ad8
parent 6d85b63f87 62ae015552
6 changed files with 28 additions and 91 deletions
--- a/.circleci/README.md
+++ b/.circleci/README.md
@ -7,22 +7,24 @@ The docker images are build locally on the developer machine:
 ```!sh
 cd .circleci/docker/

-docker build -t ethereum/solidity-buildpack-deps:ubuntu1904 -f Dockerfile.ubuntu1904 .
-docker push ethereum/solidity-buildpack-deps:ubuntu1904
+docker build -t ethereum/solidity-buildpack-deps:ubuntu1904-<revision> -f Dockerfile.ubuntu1904 .
+docker push ethereum/solidity-buildpack-deps:ubuntu1904-<revision>
 ```

-which you can find on Dockerhub after the push at:
+The current revision is `1`.

-    https://hub.docker.com/r/ethereum/solidity-buildpack-deps
+Once the docker image has been built and pushed to Dockerhub, you can find it at:

-where the image tag reflects the target OS to build Solidity and run its test on.
+    https://hub.docker.com/r/ethereum/solidity-buildpack-deps:ubuntu1904-<revision>
+
+where the image tag reflects the target OS and revision to build Solidity and run its tests on.

 ### Testing docker images locally

 ```!sh
 cd solidity
 # Mounts your local solidity directory in docker container for testing
-docker run -v `pwd`:/src/solidity -ti ethereum/solidity-buildpack-deps:ubuntu1904 /bin/bash
+docker run -v `pwd`:/src/solidity -ti ethereum/solidity-buildpack-deps:ubuntu1904-<revision> /bin/bash
 cd /src/solidity
 <commands_to_test_build_with_new_docker_image>
-```
+```
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@ -106,7 +106,7 @@ defaults:

  - test_ubuntu1904_clang: &test_ubuntu1904_clang
      docker:
-        - image: ethereum/solidity-buildpack-deps:ubuntu1904-clang
+        - image: ethereum/solidity-buildpack-deps:ubuntu1904-clang-1
      steps:
        - checkout
        - attach_workspace:
@ -117,7 +117,7 @@ defaults:

  - test_ubuntu1904: &test_ubuntu1904
      docker:
-        - image: ethereum/solidity-buildpack-deps:ubuntu1904
+        - image: ethereum/solidity-buildpack-deps:ubuntu1904-1
      steps:
        - checkout
        - attach_workspace:
@ -287,7 +287,7 @@ jobs:

  b_ubu_clang: &build_ubuntu1904_clang
    docker:
-      - image: ethereum/solidity-buildpack-deps:ubuntu1904-clang
+      - image: ethereum/solidity-buildpack-deps:ubuntu1904-clang-1
    environment:
      CC: clang
      CXX: clang++
@ -299,7 +299,7 @@ jobs:

  b_ubu: &build_ubuntu1904
    docker:
-      - image: ethereum/solidity-buildpack-deps:ubuntu1904
+      - image: ethereum/solidity-buildpack-deps:ubuntu1904-1
    steps:
      - checkout
      - run: *run_build
@ -313,7 +313,7 @@ jobs:

  b_ubu18: &build_ubuntu1804
    docker:
-      - image: ethereum/solidity-buildpack-deps:ubuntu1804
+      - image: ethereum/solidity-buildpack-deps:ubuntu1804-1
    environment:
      CMAKE_OPTIONS: -DCMAKE_CXX_FLAGS=-O2
      CMAKE_BUILD_TYPE: RelWithDebugInfo
@ -519,7 +519,7 @@ jobs:

  b_docs:
    docker:
-      - image: ethereum/solidity-buildpack-deps:ubuntu1904
+      - image: ethereum/solidity-buildpack-deps:ubuntu1904-1
    steps:
      - checkout
      - run: *setup_prerelease_commit_hash
@ -544,7 +544,7 @@ jobs:

  t_ubu_cli: &t_ubu_cli
    docker:
-      - image: ethereum/solidity-buildpack-deps:ubuntu1904
+      - image: ethereum/solidity-buildpack-deps:ubuntu1904-1
    environment:
      TERM: xterm
    steps:
--- a/.circleci/docker/Dockerfile.clang.ubuntu1904
+++ b/.circleci/docker/Dockerfile.clang.ubuntu1904
@ -89,40 +89,21 @@ RUN set -ex; \
 	ninja install/strip; \
 	rm -rf /usr/src/libprotobuf-mutator

-# ETHASH
-RUN set -ex; \
-	cd /usr/src; \
-	git clone --branch="v0.4.4" https://github.com/chfast/ethash.git; \
-	cd ethash; \
-	mkdir build; \
-	cd build; \
-	cmake .. -G Ninja -DBUILD_SHARED_LIBS=ON -DETHASH_BUILD_TESTS=OFF -DCMAKE_INSTALL_PREFIX="/usr"; \
-	ninja; \
-	ninja install/strip; \
-	rm -rf /usr/src/ethash
-
-# INTX
-RUN set -ex; \
-	cd /usr/src; \
-	git clone --branch="v0.2.0" https://github.com/chfast/intx.git; \
-	cd intx; \
-	mkdir build; \
-	cd build; \
-	cmake .. -G Ninja -DBUILD_SHARED_LIBS=ON -DINTX_TESTING=OFF -DINTX_BENCHMARKING=OFF -DCMAKE_INSTALL_PREFIX="/usr"; \
-	ninja; \
-	ninja install/strip; \
-	rm -rf /usr/src/intx;
-
 # EVMONE
 RUN set -ex; \
 	cd /usr/src; \
-	git clone --branch="v0.1.0" --recurse-submodules https://github.com/ethereum/evmone.git; \
+	git clone --branch="v0.2.0" --recurse-submodules https://github.com/ethereum/evmone.git; \
 	cd evmone; \
 	mkdir build; \
 	cd build; \
+	# isoltest links against the evmone shared library
 	cmake -G Ninja -DBUILD_SHARED_LIBS=ON -DCMAKE_INSTALL_PREFIX="/usr" ..; \
 	ninja; \
 	ninja install/strip; \
+	# abiv2_proto_ossfuzz links against the evmone standalone static library
+	cmake -G Ninja -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_PREFIX="/usr" ..; \
+	ninja; \
+	ninja install/strip; \
 	rm -rf /usr/src/evmone

 FROM base
--- a/.circleci/docker/Dockerfile.ubuntu1804
+++ b/.circleci/docker/Dockerfile.ubuntu1804
@ -74,34 +74,10 @@ RUN set -ex; \
 	ar r /usr/lib/libFuzzingEngine.a *.o; \
 	rm -rf /var/lib/libfuzzer

-# ETHASH
-RUN set -ex; \
-	cd /usr/src; \
-	git clone --branch="v0.4.4" https://github.com/chfast/ethash.git; \
-	cd ethash; \
-	mkdir build; \
-	cd build; \
-	cmake .. -G Ninja -DBUILD_SHARED_LIBS=OFF -DETHASH_BUILD_TESTS=OFF -DCMAKE_INSTALL_PREFIX="/usr"; \
-	ninja; \
-	ninja install/strip; \
-	rm -rf /usr/src/ethash
-
-# INTX
-RUN set -ex; \
-	cd /usr/src; \
-	git clone --branch="v0.2.0" https://github.com/chfast/intx.git; \
-	cd intx; \
-	mkdir build; \
-	cd build; \
-	cmake .. -G Ninja -DBUILD_SHARED_LIBS=OFF -DINTX_TESTING=OFF -DINTX_BENCHMARKING=OFF -DCMAKE_INSTALL_PREFIX="/usr"; \
-	ninja; \
-	ninja install/strip; \
-	rm -rf /usr/src/intx;
-
 # EVMONE
-ARG EVMONE_HASH="f10d12c190f55a9d373e78b2dc0074d35d752c02cb536bb6fe754fb3719dd69e"
+ARG EVMONE_HASH="81488656a53ae1bbf186d33fc69a4f5c59d3d7419b1ba1b4832a0d409b1a33bf"
 ARG EVMONE_MAJOR="0"
-ARG EVMONE_MINOR="1"
+ARG EVMONE_MINOR="2"
 ARG EVMONE_MICRO="0"
 RUN set -ex; \
 	EVMONE_VERSION="$EVMONE_MAJOR.$EVMONE_MINOR.$EVMONE_MICRO"; \
--- a/.circleci/docker/Dockerfile.ubuntu1904
+++ b/.circleci/docker/Dockerfile.ubuntu1904
@ -74,37 +74,14 @@ RUN set -ex; \
    ar r /usr/lib/libFuzzingEngine.a *.o; \
 	rm -rf /var/lib/libfuzzer

-# ETHASH
-RUN set -ex; \
-	cd /usr/src; \
-	git clone --branch="v0.4.4" https://github.com/chfast/ethash.git; \
-	cd ethash; \
-	mkdir build; \
-	cd build; \
-	cmake .. -G Ninja -DBUILD_SHARED_LIBS=OFF -DETHASH_BUILD_TESTS=OFF -DCMAKE_INSTALL_PREFIX="/usr"; \
-	ninja; \
-	ninja install/strip; \
-	rm -rf /usr/src/ethash
-
-# INTX
-RUN set -ex; \
-	cd /usr/src; \
-	git clone --branch="v0.2.0" https://github.com/chfast/intx.git; \
-	cd intx; \
-	mkdir build; \
-	cd build; \
-	cmake .. -G Ninja -DBUILD_SHARED_LIBS=OFF -DINTX_TESTING=OFF -DINTX_BENCHMARKING=OFF -DCMAKE_INSTALL_PREFIX="/usr"; \
-	ninja; \
-	ninja install/strip; \
-	rm -rf /usr/src/intx;
-
 # EVMONE
 RUN set -ex; \
 	cd /usr/src; \
-	git clone --branch="v0.1.0" --recurse-submodules https://github.com/ethereum/evmone.git; \
+	git clone --branch="v0.2.0" --recurse-submodules https://github.com/ethereum/evmone.git; \
 	cd evmone; \
 	mkdir build; \
 	cd build; \
+	# isoltest links against the evmone shared library
 	cmake -G Ninja -DBUILD_SHARED_LIBS=ON -DCMAKE_INSTALL_PREFIX="/usr" ..; \
 	ninja; \
 	ninja install/strip; \
--- a/test/tools/ossfuzz/CMakeLists.txt
+++ b/test/tools/ossfuzz/CMakeLists.txt
@ -71,7 +71,8 @@ if (OSSFUZZ)
            /usr/include/libprotobuf-mutator
    )
    target_link_libraries(abiv2_proto_ossfuzz PRIVATE solidity
-            evmc evmone intx ethash evmc-instructions
+            evmc
+            evmone-standalone
            protobuf-mutator-libfuzzer.a
            protobuf-mutator.a
            protobuf.a