cerc-io/solidity
15
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove InternalCompilerError on abstract contract instantiation.

Browse Source
This commit is contained in:
Alexander Arlt 2019-10-26 15:51:03 -05:00
parent cd3ad73b5a
commit c908c16acd
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libsolidity/analysis/TypeChecker.cpp
View File

@ -2156,6 +2156,9 @@ void TypeChecker::endVisit(NewExpression const& _newExpression)
if (contract->abstract() || !contract->annotation().unimplementedFunctions.empty()) if (contract->abstract() || !contract->annotation().unimplementedFunctions.empty())
m_errorReporter.typeError(_newExpression.location(), "Cannot instantiate an abstract contract."); m_errorReporter.typeError(_newExpression.location(), "Cannot instantiate an abstract contract.");
if (contract->abstract())
m_errorReporter.typeError(_newExpression.location(), "Cannot instantiate an abstract contract.");
solAssert(!!m_scope, ""); solAssert(!!m_scope, "");
m_scope->annotation().contractDependencies.insert(contract); m_scope->annotation().contractDependencies.insert(contract);
solAssert( solAssert(

12
test/libsolidity/syntaxTests/abstract/abstract_contract_instantiation.sol Normal file
View File

@ -0,0 +1,12 @@
abstract contract AbstractContract {
constructor() public { }
function utterance() public returns (bytes32) { return "miaow"; }
}
contract Test {
function create() public {
AbstractContract ac = new AbstractContract();
}
}
// ----
// TypeError: (215-235): Cannot instantiate an abstract contract.