cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Constants are considered pure.

Browse Source
This commit is contained in:
chriseth 2020-07-14 20:18:34 +02:00 committed by Mathias Baumann
parent d3647b13e4
commit c8772a54c3
4 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changelog.md
View File

@ -30,6 +30,7 @@ Compiler Features:
Bugfixes: Bugfixes:
* NatSpec: Constructors and functions have consistent userdoc output. * NatSpec: Constructors and functions have consistent userdoc output.
* Inheritance: Disallow public state variables overwriting ``pure`` functions. * Inheritance: Disallow public state variables overwriting ``pure`` functions.
* State Mutability: Constant public state variables are considered ``pure`` functions.
### 0.6.12 (unreleased) ### 0.6.12 (unreleased)

2
libsolidity/analysis/OverrideChecker.cpp
View File

@ -289,7 +289,7 @@ StateMutability OverrideProxy::stateMutability() const
return std::visit(GenericVisitor{ return std::visit(GenericVisitor{
[&](FunctionDefinition const* _item) { return _item->stateMutability(); }, [&](FunctionDefinition const* _item) { return _item->stateMutability(); },
[&](ModifierDefinition const*) { solAssert(false, "Requested state mutability from modifier."); return StateMutability{}; }, [&](ModifierDefinition const*) { solAssert(false, "Requested state mutability from modifier."); return StateMutability{}; },
[&](VariableDeclaration const*) { return StateMutability::View; } [&](VariableDeclaration const* _var) { return _var->isConstant() ? StateMutability::Pure : StateMutability::View; }
}, m_item); }, m_item);
} }

7
test/libsolidity/syntaxTests/inheritance/override/public_constant_var_overrides_pure.sol Normal file
View File

@ -0,0 +1,7 @@
abstract contract C {
function foo() external pure virtual returns (uint);
}
contract X is C {
uint public constant override foo = 7;
}
// ----

8
test/libsolidity/syntaxTests/inheritance/override/public_immutable_var_overrides_pure.sol Normal file
View File

@ -0,0 +1,8 @@
abstract contract C {
function foo() external pure virtual returns (uint);
}
contract X is C {
uint public immutable override foo = 7;
}
// ----
// TypeError 6959: (100-124): Overriding public state variable changes state mutability from "pure" to "view".