Merge pull request #4583 from ethereum/nested_array_library_changelog

Bugfix Changelog entry regarding nested arrays returned by library functions

test/buglistTests.js

@@ -0,0 +1,45 @@
+#!/usr/bin/env node
+
+"use strict";
+
+var fs = require('fs')
+var bugs = JSON.parse(fs.readFileSync(__dirname + '/../docs/bugs.json', 'utf8'))
+
+var bugsByName = {}
+for (var i in bugs)
+{
+    if (bugs[i].name in bugsByName)
+    {
+        throw "Duplicate bug name: " + bugs[i].name
+    }
+    bugsByName[bugs[i].name] = bugs[i]
+}
+
+var tests = fs.readFileSync(__dirname + '/buglist_test_vectors.md', 'utf8')
+
+var testVectorParser = /\s*#\s+(\S+)\s+## buggy\n([^#]*)## fine\n([^#]*)/g
+
+var result;
+while ((result = testVectorParser.exec(tests)) !== null)
+{
+    var name = result[1]
+    var buggy = result[2].split('\n--\n')
+    var fine = result[3].split('\n--\n')
+    console.log("Testing " + name + " with " + buggy.length + " buggy and " + fine.length + " fine instances")
+
+    var regex = RegExp(bugsByName[name].check['regex-source'])
+    for (var i in buggy)
+    {
+        if (!regex.exec(buggy[i]))
+        {
+            throw "Bug " + name + ": Buggy source does not match: " + buggy[i]
+        }
+    }
+    for (var i in fine)
+    {
+        if (regex.exec(fine[i]))
+        {
+            throw "Bug " + name + ": Non-buggy source matches: " + fine[i]
+        }
+    }
+}

test/buglist_test_vectors.md

@@ -0,0 +1,69 @@
+# NestedArrayFunctionCallDecoder
+
+## buggy
+
+function f() pure returns (uint[2][2]) { }
+
+--
+
+function f() returns (uint[2][2] a) { }
+
+--
+
+function f() returns (uint x, uint[200][2] a) { }
+
+--
+
+function f() returns (uint[200][2] a, uint x) { }
+
+--
+
+function f() returns (uint[200][2] a, uint x);
+
+--
+
+function f() returns (
+    uint
+    [
+    200
+    ]
+    [2]
+    a, uint x);
+
+--
+
+function f() returns (
+    uint
+    [
+    ContractName.ConstantName
+    ]
+    [2]
+    a, uint x);
+
+## fine
+
+function f() returns (uint[2]) { }
+
+--
+
+function f() public pure returns (uint[2][] a) { }
+
+--
+
+function f() public pure returns (uint[ 2 ] [ ]  a) { }
+
+--
+
+function f() public pure  returns (uint x, uint[] a) { }
+
+--
+
+function f(uint[2][2]) { }
+
+--
+
+function f() m(uint[2][2]) { }
+
+--
+
+function f() returns (uint, uint) { uint[2][2] memory x; }