cerc-io/solidity
11
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Adjust code to review findings

Browse Source
This commit is contained in:
wechman
2022-09-28 13:06:25 +02:00
parent a8bf1f255d
commit c1dc8df9c9
9 changed files with 31 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libsolidity/ast/Types.cpp
+9 -6
View File
@@ -403,20 +403,23 @@ FunctionDefinitionResult Type::userDefinedOperator(Token _token, ASTNode const&
);
solAssert(functionType && !functionType->parameterTypes().empty());
solAssert(isImplicitlyConvertibleTo(*functionType->parameterTypes().front()));
if ((_unaryOperation && function.parameterList().parameters().size() == 1) ||
(!_unaryOperation && function.parameterList().parameters().size() == 2))
if (
(_unaryOperation && function.parameterList().parameters().size() == 1) ||
(!_unaryOperation && function.parameterList().parameters().size() == 2)
)
seenFunctions.insert(&function);
}
if (seenFunctions.size() == 1)
return *seenFunctions.begin();
else if (seenFunctions.size() == 0)
return FunctionDefinitionResult::err("A user-defined operator not found.");
else if (!!typeDefinition() && seenFunctions.size() == 0)
return FunctionDefinitionResult::err("Operator has not been user-defined.");
else if (!!typeDefinition())
return FunctionDefinitionResult::err("Multiple user-defined functions provided for this operator.");
else
return FunctionDefinitionResult::err("A user-defined operator not unique.");
return nullptr;
}
MemberList::MemberMap Type::boundFunctions(Type const& _type, ASTNode const& _scope)
{
MemberList::MemberMap members;