cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

prepare_report: Add YulException to the list of ICEs for which we ignore Standard JSON outputs even when present

Browse Source
This commit is contained in:
Kamil Śliwak 2023-06-28 17:28:41 +02:00
parent 23955ba428
commit bccfcd40a0
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scripts/bytecodecompare/prepare_report.js
View File

@ -100,7 +100,7 @@ for (const preset of presets)
// JSON interface still returns contract metadata in case of an internal compiler error while // JSON interface still returns contract metadata in case of an internal compiler error while
// CLI interface does not. To make reports comparable we must force this case to be detected as // CLI interface does not. To make reports comparable we must force this case to be detected as
// an error in both cases. // an error in both cases.
if (['UnimplementedFeatureError', 'CompilerError', 'CodeGenerationError'].includes(error['type'])) if (['UnimplementedFeatureError', 'CompilerError', 'CodeGenerationError', 'YulException'].includes(error['type']))
{ {
internalCompilerError = true internalCompilerError = true
break break

2
scripts/bytecodecompare/prepare_report.py
View File

@ -157,7 +157,7 @@ def parse_standard_json_output(source_file_name: Path, standard_json_output: str
# CLI interface does not. To make reports comparable we must force this case to be detected as # CLI interface does not. To make reports comparable we must force this case to be detected as
# an error in both cases. # an error in both cases.
internal_compiler_error = any( internal_compiler_error = any(
error['type'] in ['UnimplementedFeatureError', 'CompilerError', 'CodeGenerationError'] error['type'] in ['UnimplementedFeatureError', 'CompilerError', 'CodeGenerationError', 'YulException']
for error in decoded_json_output.get('errors', {}) for error in decoded_json_output.get('errors', {})
) )