mirror of
https://github.com/ethereum/solidity
synced 2023-10-03 13:03:40 +00:00
Warn for assembly labels too
This commit is contained in:
parent
37b66616fb
commit
bc875f6b9c
@ -1,6 +1,7 @@
|
||||
### 0.4.20 (unreleased)
|
||||
|
||||
Features:
|
||||
* Inline Assembly: Issue warning for using jump labels (already existed for jump instructions).
|
||||
|
||||
Bugfixes:
|
||||
|
||||
|
@ -56,6 +56,7 @@ bool AsmAnalyzer::operator()(Label const& _label)
|
||||
{
|
||||
solAssert(!m_julia, "");
|
||||
m_info.stackHeightInfo[&_label] = m_stackHeight;
|
||||
warnOnInstructions(solidity::Instruction::JUMPDEST, _label.location);
|
||||
return true;
|
||||
}
|
||||
|
||||
@ -523,10 +524,10 @@ void AsmAnalyzer::warnOnInstructions(solidity::Instruction _instr, SourceLocatio
|
||||
"the Metropolis hard fork. Before that it acts as an invalid instruction."
|
||||
);
|
||||
|
||||
if (_instr == solidity::Instruction::JUMP || _instr == solidity::Instruction::JUMPI)
|
||||
if (_instr == solidity::Instruction::JUMP || _instr == solidity::Instruction::JUMPI || _instr == solidity::Instruction::JUMPDEST)
|
||||
m_errorReporter.warning(
|
||||
_location,
|
||||
"Jump instructions are low-level EVM features that can lead to "
|
||||
"Jump instructions and labels are low-level EVM features that can lead to "
|
||||
"incorrect stack access. Because of that they are discouraged. "
|
||||
"Please consider using \"switch\" or \"for\" statements instead."
|
||||
);
|
||||
|
@ -714,6 +714,7 @@ BOOST_AUTO_TEST_CASE(jump_warning)
|
||||
CHECK_PARSE_WARNING("{ 1 2 jumpi }", Warning, "Jump instructions");
|
||||
CHECK_PARSE_WARNING("{ a: jump(a) }", Warning, "Jump instructions");
|
||||
CHECK_PARSE_WARNING("{ a: jumpi(a, 2) }", Warning, "Jump instructions");
|
||||
CHECK_PARSE_WARNING("{ a: }", Warning, "Jump instructions");
|
||||
}
|
||||
|
||||
BOOST_AUTO_TEST_SUITE_END()
|
||||
|
Loading…
Reference in New Issue
Block a user