cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #4769 from ethereum/inlineasm-overloading-resolution

Browse Source 
Provide nicer error message when referencing overloaded references
This commit is contained in:
Alex Beregszaszi 2018-08-08 17:55:10 +01:00 committed by GitHub
commit bb071f3075
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changelog.md
View File

@ -73,6 +73,7 @@ Language Features:
Compiler Features: Compiler Features:
* C API (``libsolc``): Export the ``solidity_license``, ``solidity_version`` and ``solidity_compile`` methods. * C API (``libsolc``): Export the ``solidity_license``, ``solidity_version`` and ``solidity_compile`` methods.
* Type Checker: Nicer error message when trying to reference overloaded identifiers in inline assembly.
* Type Checker: Show named argument in case of error. * Type Checker: Show named argument in case of error.
* Tests: Determine transaction status during IPC calls. * Tests: Determine transaction status during IPC calls.
* Code Generator: Allocate and free local variables according to their scope. * Code Generator: Allocate and free local variables according to their scope.

3
libsolidity/analysis/ReferencesResolver.cpp
View File

@ -264,7 +264,10 @@ bool ReferencesResolver::visit(InlineAssembly const& _inlineAssembly)
declarations = m_resolver.nameFromCurrentScope(realName); declarations = m_resolver.nameFromCurrentScope(realName);
} }
if (declarations.size() != 1) if (declarations.size() != 1)
{
declarationError(_identifier.location, "Multiple matching identifiers. Resolving overloaded identifiers is not supported.");
return size_t(-1); return size_t(-1);
}
if (auto var = dynamic_cast<VariableDeclaration const*>(declarations.front())) if (auto var = dynamic_cast<VariableDeclaration const*>(declarations.front()))
if (var->isLocalVariable() && _crossesFunctionBoundary) if (var->isLocalVariable() && _crossesFunctionBoundary)
{ {

11
test/libsolidity/syntaxTests/inlineAssembly/overloaded_reference.sol Normal file
View File

@ -0,0 +1,11 @@
contract C {
function f() pure public {}
function f(address) pure public {}
function g() pure public {
assembly {
let x := f
}
}
}
// ----
// DeclarationError: (155-156): Multiple matching identifiers. Resolving overloaded identifiers is not supported.