cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

SMTSolverCommand: Use pipe instead of temporary file for the query

Browse Source
This commit is contained in:
Martin Blicha 2023-08-09 12:08:29 +02:00
parent 3f22118bbe
commit b8f89fa45d
1 changed files with 14 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
libsolidity/interface/SMTSolverCommand.cpp
View File

@ -22,12 +22,9 @@
#include <libsolutil/CommonIO.h> #include <libsolutil/CommonIO.h>
#include <libsolutil/Exceptions.h> #include <libsolutil/Exceptions.h>
#include <libsolutil/Keccak256.h> #include <libsolutil/Keccak256.h>
#include <libsolutil/TemporaryDirectory.h>
#include <boost/algorithm/string/join.hpp> #include <boost/algorithm/string/join.hpp>
#include <boost/algorithm/string/predicate.hpp> #include <boost/algorithm/string/predicate.hpp>
#include <boost/filesystem.hpp>
#include <boost/filesystem/fstream.hpp>
#include <boost/process.hpp> #include <boost/process.hpp>
using solidity::langutil::InternalCompilerError; using solidity::langutil::InternalCompilerError;
@ -47,35 +44,36 @@ ReadCallback::Result SMTSolverCommand::solve(std::string const& _kind, std::stri
if (kind != ReadCallback::kindString(ReadCallback::Kind::SMTQuery)) if (kind != ReadCallback::kindString(ReadCallback::Kind::SMTQuery))
solAssert(false, "SMTQuery callback used as callback kind " + kind); solAssert(false, "SMTQuery callback used as callback kind " + kind);
auto tempDir = solidity::util::TemporaryDirectory("smt");
util::h256 queryHash = util::keccak256(_query);
auto queryFileName = tempDir.path() / ("query_" + queryHash.hex() + ".smt2");
auto queryFile = boost::filesystem::ofstream(queryFileName);
queryFile << _query << std::flush;
std::vector<std::string> commandArgs; std::vector<std::string> commandArgs;
boost::split(commandArgs, solverCommand, boost::is_any_of(" ")); boost::split(commandArgs, solverCommand, boost::is_any_of(" "));
solAssert(commandArgs.size() > 0, "SMT command was empty"); solAssert(commandArgs.size() > 0, "SMT command was empty");
auto const& solverBinary = commandArgs[0]; auto solverBinary = commandArgs[0];
auto pathToBinary = boost::process::search_path(solverBinary); auto pathToBinary = boost::process::search_path(solverBinary);
if (pathToBinary.empty()) if (pathToBinary.empty())
return ReadCallback::Result{false, solverBinary + " binary not found."}; return ReadCallback::Result{false, solverBinary + " binary not found."};
commandArgs.erase(commandArgs.begin()); commandArgs.erase(commandArgs.begin());
commandArgs.push_back(queryFileName.string());
boost::process::ipstream pipe; if (solverBinary == "z3")
commandArgs.insert(commandArgs.begin(), "-in");
boost::process::opstream in; // input to subprocess written to by main process
boost::process::ipstream out; // output from subprocess read by main process
boost::process::child solver( boost::process::child solver(
pathToBinary, pathToBinary,
boost::process::args(commandArgs), boost::process::args(commandArgs),
boost::process::std_out > pipe boost::process::std_out > out,
boost::process::std_in < in
); );
in << _query << std::flush;
in.pipe().close();
in.close();
std::vector<std::string> data; std::vector<std::string> data;
std::string line; std::string line;
while (solver.running() && std::getline(pipe, line)) while (solver.running() && std::getline(out, line))
if (!line.empty()) if (!line.empty())
data.push_back(line); data.push_back(line);