Merge pull request #5526 from ethereum/fixGetterNewCoder

Fix: Disallow structs in getters for old encoder.

test/libsolidity/syntaxTests/getter/complex_struct.sol

@@ -0,0 +1,7 @@
+contract C {
+    struct Y {
+        uint a;
+        uint b;
+    }
+    mapping(uint256 => Y) public m;
+}

test/libsolidity/syntaxTests/getter/nested_structs.sol

@@ -0,0 +1,11 @@
+contract C {
+    struct Y {
+        uint b;
+    }
+    struct X {
+        Y a;
+    }
+    mapping(uint256 => X) public m;
+}
+// ----
+// TypeError: (88-118): The following types are only supported for getters in the new experimental ABI encoder: struct C.Y memory. Either remove "public" or use "pragma experimental ABIEncoderV2;" to enable the feature.

test/libsolidity/syntaxTests/getter/recursive_struct.sol

@@ -0,0 +1,8 @@
+contract C {
+    struct Y {
+        Y[] x;
+    }
+    mapping(uint256 => Y) public m;
+}
+// ----
+// TypeError: (53-83): Internal or recursive type is not allowed for public state variables.

test/libsolidity/syntaxTests/getter/simple_struct.sol

@@ -0,0 +1,6 @@
+contract C {
+    struct Y {
+        uint b;
+    }
+    mapping(uint256 => Y) public m;
+}