mirror of
https://github.com/ethereum/solidity
synced 2023-10-03 13:03:40 +00:00
Merge pull request #839 from chriseth/checkcode
BREAKING: Make function calls throw if target does not have code.
This commit is contained in:
@@ -1524,6 +1524,13 @@ void ExpressionCompiler::appendExternalFunctionCall(
|
||||
m_context << u256(0);
|
||||
m_context << dupInstruction(m_context.baseToCurrentStackOffset(contractStackPos));
|
||||
|
||||
// Check the the target contract exists (has code) for non-low-level calls.
|
||||
if (funKind == FunctionKind::External || funKind == FunctionKind::CallCode || funKind == FunctionKind::DelegateCall)
|
||||
{
|
||||
m_context << Instruction::DUP1 << Instruction::EXTCODESIZE << Instruction::ISZERO;
|
||||
m_context.appendConditionalJumpTo(m_context.errorTag());
|
||||
}
|
||||
|
||||
if (_functionType.gasSet())
|
||||
m_context << dupInstruction(m_context.baseToCurrentStackOffset(gasStackPos));
|
||||
else
|
||||
|
||||
Reference in New Issue
Block a user