Remove ROL/ROR as they are not part of EIP145 anymore

This commit is contained in:
Alex Beregszaszi 2017-07-09 08:42:54 +01:00
parent 468d0f6199
commit afa4a48e37
4 changed files with 1 additions and 13 deletions

View File

@ -212,10 +212,6 @@ In the grammar, opcodes are represented as pre-defined identifiers.
+-------------------------+-----+---+-----------------------------------------------------------------+
| sar(x, y) | | C | arithmetic shift right x by y bits |
+-------------------------+-----+---+-----------------------------------------------------------------+
| ror(x, y) | | C | rotate right x by y bits |
+-------------------------+-----+---+-----------------------------------------------------------------+
| rol(x, y) | | C | rotate left x by y bits |
+-------------------------+-----+---+-----------------------------------------------------------------+
| addmod(x, y, m) | | F | (x + y) % m with arbitrary precision arithmetics |
+-------------------------+-----+---+-----------------------------------------------------------------+
| mulmod(x, y, m) | | F | (x * y) % m with arbitrary precision arithmetics |

View File

@ -53,8 +53,6 @@ const std::map<std::string, Instruction> dev::solidity::c_instructions =
{ "SHL", Instruction::SHL },
{ "SHR", Instruction::SHR },
{ "SAR", Instruction::SAR },
{ "ROL", Instruction::ROL },
{ "ROR", Instruction::ROR },
{ "ADDMOD", Instruction::ADDMOD },
{ "MULMOD", Instruction::MULMOD },
{ "SIGNEXTEND", Instruction::SIGNEXTEND },
@ -198,8 +196,6 @@ static const std::map<Instruction, InstructionInfo> c_instructionInfo =
{ Instruction::SHL, { "SHL", 0, 2, 1, false, Tier::VeryLow } },
{ Instruction::SHR, { "SHR", 0, 2, 1, false, Tier::VeryLow } },
{ Instruction::SAR, { "SAR", 0, 2, 1, false, Tier::VeryLow } },
{ Instruction::ROL, { "ROL", 0, 2, 1, false, Tier::VeryLow } },
{ Instruction::ROR, { "ROR", 0, 2, 1, false, Tier::VeryLow } },
{ Instruction::ADDMOD, { "ADDMOD", 0, 3, 1, false, Tier::Mid } },
{ Instruction::MULMOD, { "MULMOD", 0, 3, 1, false, Tier::Mid } },
{ Instruction::SIGNEXTEND, { "SIGNEXTEND", 0, 2, 1, false, Tier::Low } },

View File

@ -64,8 +64,6 @@ enum class Instruction: uint8_t
SHL, ///< bitwise SHL operation
SHR, ///< bitwise SHR operation
SAR, ///< bitwise SAR operation
ROL, ///< bitwise ROL operation
ROR, ///< bitwise ROR operation
KECCAK256 = 0x20, ///< compute KECCAK-256 hash

View File

@ -551,9 +551,7 @@ void AsmAnalyzer::warnOnInstructions(solidity::Instruction _instr, SourceLocatio
static set<solidity::Instruction> experimentalInstructions{
solidity::Instruction::SHL,
solidity::Instruction::SHR,
solidity::Instruction::SAR,
solidity::Instruction::ROL,
solidity::Instruction::ROR
solidity::Instruction::SAR
};
if (experimentalInstructions.count(_instr))
m_errorReporter.warning(