cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Disallowing usage of msg.data in receive() function.

Browse Source
This commit is contained in:
Djordje Mijovic 2020-12-08 09:12:55 +01:00
parent 4368a3b3eb
commit acb93f3a97
3 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changelog.md
View File

@ -19,6 +19,7 @@ Breaking Changes:
* Type System: Explicit conversions between two types are disallowed if it changes more than one of sign, width or kind at the same time. * Type System: Explicit conversions between two types are disallowed if it changes more than one of sign, width or kind at the same time.
* Type System: Declarations with the name ``this``, ``super`` and ``_`` are disallowed, with the exception of public functions and events. * Type System: Declarations with the name ``this``, ``super`` and ``_`` are disallowed, with the exception of public functions and events.
* Type System: Disallow ``type(super)``. * Type System: Disallow ``type(super)``.
* Type System: Disallow ``msg.data`` in ``receive()`` function.
* Command Line Interface: JSON fields `abi`, `devdoc`, `userdoc` and `storage-layout` are now sub-objects rather than strings. * Command Line Interface: JSON fields `abi`, `devdoc`, `userdoc` and `storage-layout` are now sub-objects rather than strings.
* Scanner: Remove support for the ``\b``, ``\f``, and ``\v`` escape sequences. * Scanner: Remove support for the ``\b``, ``\f``, and ``\v`` escape sequences.

11
libsolidity/analysis/StaticAnalyzer.cpp
View File

@ -224,6 +224,17 @@ bool StaticAnalyzer::visit(MemberAccess const& _memberAccess)
"Because of that, it might be that the deployed bytecode is different from type(...).runtimeCode." "Because of that, it might be that the deployed bytecode is different from type(...).runtimeCode."
); );
} }
else if (
m_currentFunction &&
m_currentFunction->isReceive() &&
type->kind() == MagicType::Kind::Message &&
_memberAccess.memberName() == "data"
)
m_errorReporter.typeError(
7139_error,
_memberAccess.location(),
R"("msg.data" cannot be used inside of "receive" function.)"
);
} }
if (_memberAccess.memberName() == "callcode") if (_memberAccess.memberName() == "callcode")

5
test/libsolidity/syntaxTests/receiveEther/msg_data_in_receive.sol Normal file
View File

@ -0,0 +1,5 @@
contract C {
receive() external payable { msg.data; }
}
// ----
// TypeError 7139: (46-54): "msg.data" cannot be used inside of "receive" function.