cerc-io/solidity
11
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Ensure parameter names match between headers and implementation

Browse Source
This commit is contained in:
Alex Beregszaszi
2017-09-20 01:23:21 +01:00
parent 137b214be4
commit aad829948a
10 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libsolidity/analysis/DocStringAnalyser.cpp
+8 -8
View File
@@ -38,30 +38,30 @@ bool DocStringAnalyser::analyseDocStrings(SourceUnit const& _sourceUnit)
return !m_errorOccured;
}
bool DocStringAnalyser::visit(ContractDefinition const& _node)
bool DocStringAnalyser::visit(ContractDefinition const& _contract)
{
static const set<string> validTags = set<string>{"author", "title", "dev", "notice"};
parseDocStrings(_node, _node.annotation(), validTags, "contracts");
parseDocStrings(_contract, _contract.annotation(), validTags, "contracts");
return true;
}
bool DocStringAnalyser::visit(FunctionDefinition const& _node)
bool DocStringAnalyser::visit(FunctionDefinition const& _function)
{
handleCallable(_node, _node, _node.annotation());
handleCallable(_function, _function, _function.annotation());
return true;
}
bool DocStringAnalyser::visit(ModifierDefinition const& _node)
bool DocStringAnalyser::visit(ModifierDefinition const& _modifier)
{
handleCallable(_node, _node, _node.annotation());
handleCallable(_modifier, _modifier, _modifier.annotation());
return true;
}
bool DocStringAnalyser::visit(EventDefinition const& _node)
bool DocStringAnalyser::visit(EventDefinition const& _event)
{
handleCallable(_node, _node, _node.annotation());
handleCallable(_event, _event, _event.annotation());
return true;
}
libsolidity/analysis/NameAndTypeResolver.h
+1 -1
View File
@@ -148,7 +148,7 @@ public:
private:
bool visit(SourceUnit& _sourceUnit) override;
void endVisit(SourceUnit& _sourceUnit) override;
bool visit(ImportDirective& _declaration) override;
bool visit(ImportDirective& _import) override;
bool visit(ContractDefinition& _contract) override;
void endVisit(ContractDefinition& _contract) override;
bool visit(StructDefinition& _struct) override;
libsolidity/analysis/PostTypeChecker.h
+2 -2
View File
@@ -50,8 +50,8 @@ private:
virtual bool visit(ContractDefinition const& _contract) override;
virtual void endVisit(ContractDefinition const& _contract) override;
virtual bool visit(VariableDeclaration const& _declaration) override;
virtual void endVisit(VariableDeclaration const& _declaration) override;
virtual bool visit(VariableDeclaration const& _variable) override;
virtual void endVisit(VariableDeclaration const& _variable) override;
virtual bool visit(Identifier const& _identifier) override;
libsolidity/codegen/ContractCompiler.h
+2 -2
View File
@@ -96,8 +96,8 @@ private:
virtual bool visit(IfStatement const& _ifStatement) override;
virtual bool visit(WhileStatement const& _whileStatement) override;
virtual bool visit(ForStatement const& _forStatement) override;
virtual bool visit(Continue const& _continue) override;
virtual bool visit(Break const& _break) override;
virtual bool visit(Continue const& _continueStatement) override;
virtual bool visit(Break const& _breakStatement) override;
virtual bool visit(Return const& _return) override;
virtual bool visit(Throw const& _throw) override;
virtual bool visit(VariableDeclarationStatement const& _variableDeclarationStatement) override;
libsolidity/interface/ErrorReporter.h
+1 -1
View File
@@ -86,7 +86,7 @@ public:
void fatalTypeError(SourceLocation const& _location, std::string const& _description);
void docstringParsingError(std::string const& _location);
void docstringParsingError(std::string const& _description);
ErrorList const& errors() const;