From 75f7f7e1e69329ec0413e51979fefd23c9b982f7 Mon Sep 17 00:00:00 2001 From: chriseth Date: Wed, 5 Jul 2017 17:02:02 +0200 Subject: [PATCH] Do not omit error type. --- Changelog.md | 1 + libsolidity/interface/StandardCompiler.cpp | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Changelog.md b/Changelog.md index b44159785..de4207a99 100644 --- a/Changelog.md +++ b/Changelog.md @@ -2,6 +2,7 @@ Bugfixes: * Code Generator: Correctly unregister modifier variables. + * Error Output: Do not omit the error type. ### 0.4.12 (2017-07-03) diff --git a/libsolidity/interface/StandardCompiler.cpp b/libsolidity/interface/StandardCompiler.cpp index e677afc87..1f51851d5 100644 --- a/libsolidity/interface/StandardCompiler.cpp +++ b/libsolidity/interface/StandardCompiler.cpp @@ -71,7 +71,7 @@ Json::Value formatErrorWithException( ) { string message; - string formattedMessage = SourceReferenceFormatter::formatExceptionInformation(_exception, _message, _scannerFromSourceName); + string formattedMessage = SourceReferenceFormatter::formatExceptionInformation(_exception, _type, _scannerFromSourceName); // NOTE: the below is partially a copy from SourceReferenceFormatter SourceLocation const* location = boost::get_error_info(_exception); @@ -271,12 +271,12 @@ Json::Value StandardCompiler::compileInternal(Json::Value const& _input) for (auto const& error: m_compilerStack.errors()) { - auto err = dynamic_pointer_cast(error); + Error const& err = dynamic_cast(*error); errors.append(formatErrorWithException( *error, - err->type() == Error::Type::Warning, - err->typeName(), + err.type() == Error::Type::Warning, + err.typeName(), "general", "", scannerFromSourceName