cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Stricter explicit conversions from Literals to Integers.

Browse Source 
Explicit conversions from Literals to Integers will now be as strict as implicit conversions between
the same.
This commit is contained in:
hrkrshnn 2020-10-26 10:59:08 +01:00
parent 5ffee049fa
commit a555556559
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
libsolidity/ast/Types.cpp
View File

@ -129,10 +129,13 @@ BoolResult fitsIntegerType(bigint const& _value, IntegerType const& _type)
/// if _signed is true. /// if _signed is true.
bool fitsIntoBits(bigint const& _value, unsigned _bits, bool _signed) bool fitsIntoBits(bigint const& _value, unsigned _bits, bool _signed)
{ {
return fitsIntegerType(_value, *TypeProvider::integer( return fitsIntegerType(
_value,
*TypeProvider::integer(
_bits, _bits,
_signed ? IntegerType::Modifier::Signed : IntegerType::Modifier::Unsigned _signed ? IntegerType::Modifier::Signed : IntegerType::Modifier::Unsigned
)); )
);
} }
util::Result<TypePointers> transformParametersToExternal(TypePointers const& _parameters, bool _inLibrary) util::Result<TypePointers> transformParametersToExternal(TypePointers const& _parameters, bool _inLibrary)
@ -968,9 +971,13 @@ BoolResult RationalNumberType::isExplicitlyConvertibleTo(Type const& _convertTo)
auto category = _convertTo.category(); auto category = _convertTo.category();
if (category == Category::FixedBytes) if (category == Category::FixedBytes)
return false; return false;
if (category == Category::Address) else if (category == Category::Address)
{
if (isNegative() || isFractional() || integerType()->numBits() > 160) if (isNegative() || isFractional() || integerType()->numBits() > 160)
return false; return false;
}
else if (category == Category::Integer)
return false;
TypePointer mobType = mobileType(); TypePointer mobType = mobileType();
return (mobType && mobType->isExplicitlyConvertibleTo(_convertTo)); return (mobType && mobType->isExplicitlyConvertibleTo(_convertTo));