cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #10074 from ethereum/smt_fix_unknown

Browse Source 
Add unknown message to all verification targets
This commit is contained in:
chriseth 2020-10-20 15:45:39 +02:00 committed by GitHub
commit a384e14bcc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
18 changed files with 36 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Changelog.md
View File

@ -1,6 +1,10 @@
### 0.7.5 (unreleased) ### 0.7.5 (unreleased)
Bugfixes:
* SMTChecker: Fix lack of reporting potential violations when using only the CHC engine.
### 0.7.4 (2020-10-19) ### 0.7.4 (2020-10-19)

17
libsolidity/formal/CHC.cpp
View File

@ -1215,22 +1215,25 @@ void CHC::checkVerificationTargets()
if (!intType) if (!intType)
intType = TypeProvider::uint256(); intType = TypeProvider::uint256();
satMsgUnderflow = "Underflow (resulting value less than " + formatNumberReadable(intType->minValue()) + ") happens here."; satMsgUnderflow = "Underflow (resulting value less than " + formatNumberReadable(intType->minValue()) + ")";
satMsgOverflow = "Overflow (resulting value larger than " + formatNumberReadable(intType->maxValue()) + ") happens here."; satMsgOverflow = "Overflow (resulting value larger than " + formatNumberReadable(intType->maxValue()) + ")";
if (target.type == VerificationTarget::Type::Underflow) if (target.type == VerificationTarget::Type::Underflow)
{ {
satMsg = satMsgUnderflow; satMsg = satMsgUnderflow + " happens here.";
unknownMsg = satMsgUnderflow + " might happen here.";
errorReporterId = underflowErrorId; errorReporterId = underflowErrorId;
} }
else if (target.type == VerificationTarget::Type::Overflow) else if (target.type == VerificationTarget::Type::Overflow)
{ {
satMsg = satMsgOverflow; satMsg = satMsgOverflow + " happens here.";
unknownMsg = satMsgOverflow + " might happen here.";
errorReporterId = overflowErrorId; errorReporterId = overflowErrorId;
} }
} }
else if (target.type == VerificationTarget::Type::DivByZero) else if (target.type == VerificationTarget::Type::DivByZero)
{ {
satMsg = "Division by zero happens here."; satMsg = "Division by zero happens here.";
unknownMsg = "Division by zero might happen here.";
errorReporterId = 4281_error; errorReporterId = 4281_error;
} }
else else
@ -1246,12 +1249,12 @@ void CHC::checkVerificationTargets()
{ {
auto specificTarget = target; auto specificTarget = target;
specificTarget.type = VerificationTarget::Type::Underflow; specificTarget.type = VerificationTarget::Type::Underflow;
checkAndReportTarget(scope, specificTarget, errorId, underflowErrorId, satMsgUnderflow, unknownMsg); checkAndReportTarget(scope, specificTarget, errorId, underflowErrorId, satMsgUnderflow + " happens here.", satMsgUnderflow + " might happen here.");
++it; ++it;
solAssert(it != m_errorIds.end(), ""); solAssert(it != m_errorIds.end(), "");
specificTarget.type = VerificationTarget::Type::Overflow; specificTarget.type = VerificationTarget::Type::Overflow;
checkAndReportTarget(scope, specificTarget, it->second, overflowErrorId, satMsgOverflow, unknownMsg); checkAndReportTarget(scope, specificTarget, it->second, overflowErrorId, satMsgOverflow + " happens here.", satMsgOverflow + " might happen here.");
} }
} }
} }
@ -1267,7 +1270,7 @@ void CHC::checkAssertTarget(ASTNode const* _scope, CHCVerificationTarget const&
solAssert(it != m_errorIds.end(), ""); solAssert(it != m_errorIds.end(), "");
unsigned errorId = it->second; unsigned errorId = it->second;
checkAndReportTarget(assertion, _target, errorId, 6328_error, "Assertion violation happens here."); checkAndReportTarget(assertion, _target, errorId, 6328_error, "Assertion violation happens here.", "Assertion violation might happen here.");
} }
} }

3
test/libsolidity/smtCheckerTests/crypto/crypto_functions_fail.sol
View File

@ -24,8 +24,11 @@ contract C {
} }
// ---- // ----
// Warning 1218: (168-184): CHC: Error trying to invoke SMT solver. // Warning 1218: (168-184): CHC: Error trying to invoke SMT solver.
// Warning 6328: (168-184): CHC: Assertion violation might happen here.
// Warning 1218: (305-321): CHC: Error trying to invoke SMT solver. // Warning 1218: (305-321): CHC: Error trying to invoke SMT solver.
// Warning 6328: (305-321): CHC: Assertion violation might happen here.
// Warning 1218: (448-464): CHC: Error trying to invoke SMT solver. // Warning 1218: (448-464): CHC: Error trying to invoke SMT solver.
// Warning 6328: (448-464): CHC: Assertion violation might happen here.
// Warning 6328: (673-689): CHC: Assertion violation happens here. // Warning 6328: (673-689): CHC: Assertion violation happens here.
// Warning 4661: (168-184): BMC: Assertion violation happens here. // Warning 4661: (168-184): BMC: Assertion violation happens here.
// Warning 4661: (305-321): BMC: Assertion violation happens here. // Warning 4661: (305-321): BMC: Assertion violation happens here.

3
test/libsolidity/smtCheckerTests/crypto/crypto_functions_same_input_over_state_same_output_fail.sol
View File

@ -46,8 +46,11 @@ contract C {
} }
// ---- // ----
// Warning 1218: (726-745): CHC: Error trying to invoke SMT solver. // Warning 1218: (726-745): CHC: Error trying to invoke SMT solver.
// Warning 6328: (726-745): CHC: Assertion violation might happen here.
// Warning 1218: (749-768): CHC: Error trying to invoke SMT solver. // Warning 1218: (749-768): CHC: Error trying to invoke SMT solver.
// Warning 6328: (749-768): CHC: Assertion violation might happen here.
// Warning 1218: (772-791): CHC: Error trying to invoke SMT solver. // Warning 1218: (772-791): CHC: Error trying to invoke SMT solver.
// Warning 6328: (772-791): CHC: Assertion violation might happen here.
// Warning 6328: (795-814): CHC: Assertion violation happens here. // Warning 6328: (795-814): CHC: Assertion violation happens here.
// Warning 4661: (726-745): BMC: Assertion violation happens here. // Warning 4661: (726-745): BMC: Assertion violation happens here.
// Warning 4661: (749-768): BMC: Assertion violation happens here. // Warning 4661: (749-768): BMC: Assertion violation happens here.

1
test/libsolidity/smtCheckerTests/imports/import_base.sol
View File

@ -18,6 +18,7 @@ contract Der is Base {
} }
} }
// ---- // ----
// Warning 4984: (der:101-109): CHC: Overflow (resulting value larger than 2**256 - 1) might happen here.
// Warning 6328: (der:113-126): CHC: Assertion violation happens here. // Warning 6328: (der:113-126): CHC: Assertion violation happens here.
// Warning 2661: (base:100-103): BMC: Overflow (resulting value larger than 2**256 - 1) happens here. // Warning 2661: (base:100-103): BMC: Overflow (resulting value larger than 2**256 - 1) happens here.
// Warning 2661: (der:101-109): BMC: Overflow (resulting value larger than 2**256 - 1) happens here. // Warning 2661: (der:101-109): BMC: Overflow (resulting value larger than 2**256 - 1) happens here.

1
test/libsolidity/smtCheckerTests/invariants/loop_nested_for.sol
View File

@ -13,4 +13,5 @@ contract Simple {
} }
} }
// ---- // ----
// Warning 6328: (187-201): CHC: Assertion violation might happen here.
// Warning 4661: (187-201): BMC: Assertion violation happens here. // Warning 4661: (187-201): BMC: Assertion violation happens here.

1
test/libsolidity/smtCheckerTests/loops/for_1_fail.sol
View File

@ -14,5 +14,6 @@ contract C
// ==== // ====
// SMTSolvers: z3 // SMTSolvers: z3
// ---- // ----
// Warning 4984: (176-181): CHC: Overflow (resulting value larger than 2**256 - 1) might happen here.
// Warning 6328: (189-203): CHC: Assertion violation happens here. // Warning 6328: (189-203): CHC: Assertion violation happens here.
// Warning 2661: (176-181): BMC: Overflow (resulting value larger than 2**256 - 1) happens here. // Warning 2661: (176-181): BMC: Overflow (resulting value larger than 2**256 - 1) happens here.

1
test/libsolidity/smtCheckerTests/loops/for_1_false_positive.sol
View File

@ -14,4 +14,5 @@ contract C
} }
} }
// ---- // ----
// Warning 4984: (176-181): CHC: Overflow (resulting value larger than 2**256 - 1) might happen here.
// Warning 2661: (176-181): BMC: Overflow (resulting value larger than 2**256 - 1) happens here. // Warning 2661: (176-181): BMC: Overflow (resulting value larger than 2**256 - 1) happens here.

1
test/libsolidity/smtCheckerTests/loops/while_loop_array_assignment_memory_memory.sol
View File

@ -20,5 +20,6 @@ contract LoopFor2 {
// ==== // ====
// SMTSolvers: z3 // SMTSolvers: z3
// ---- // ----
// Warning 4984: (244-249): CHC: Overflow (resulting value larger than 2**256 - 1) might happen here.
// Warning 6328: (373-392): CHC: Assertion violation happens here. // Warning 6328: (373-392): CHC: Assertion violation happens here.
// Warning 6328: (396-415): CHC: Assertion violation happens here. // Warning 6328: (396-415): CHC: Assertion violation happens here.

1
test/libsolidity/smtCheckerTests/loops/while_loop_array_assignment_memory_storage.sol
View File

@ -25,3 +25,4 @@ contract LoopFor2 {
// ==== // ====
// SMTSolvers: z3 // SMTSolvers: z3
// ---- // ----
// Warning 4984: (237-242): CHC: Overflow (resulting value larger than 2**256 - 1) might happen here.

1
test/libsolidity/smtCheckerTests/loops/while_loop_array_assignment_storage_storage.sol
View File

@ -20,5 +20,6 @@ contract LoopFor2 {
} }
} }
// ---- // ----
// Warning 4984: (229-234): CHC: Overflow (resulting value larger than 2**256 - 1) might happen here.
// Warning 6328: (290-309): CHC: Assertion violation happens here. // Warning 6328: (290-309): CHC: Assertion violation happens here.
// Warning 6328: (313-332): CHC: Assertion violation happens here. // Warning 6328: (313-332): CHC: Assertion violation happens here.

1
test/libsolidity/smtCheckerTests/operators/compound_bitwise_or_int_1.sol
View File

@ -9,3 +9,4 @@ contract C {
} }
} }
// ---- // ----
// Warning 6328: (174-212): CHC: Assertion violation might happen here.

1
test/libsolidity/smtCheckerTests/operators/compound_bitwise_or_uint_1.sol
View File

@ -9,3 +9,4 @@ contract C {
} }
} }
// ---- // ----
// Warning 6328: (166-183): CHC: Assertion violation might happen here.

1
test/libsolidity/smtCheckerTests/operators/compound_bitwise_or_uint_2.sol
View File

@ -11,4 +11,5 @@ contract C {
} }
} }
// ---- // ----
// Warning 6328: (173-192): CHC: Assertion violation might happen here.
// Warning 7812: (173-192): BMC: Assertion violation might happen here. // Warning 7812: (173-192): BMC: Assertion violation might happen here.

1
test/libsolidity/smtCheckerTests/operators/compound_bitwise_or_uint_3.sol
View File

@ -10,4 +10,5 @@ contract C {
} }
} }
// ---- // ----
// Warning 6328: (157-172): CHC: Assertion violation might happen here.
// Warning 7812: (157-172): BMC: Assertion violation might happen here. // Warning 7812: (157-172): BMC: Assertion violation might happen here.

1
test/libsolidity/smtCheckerTests/operators/mod_signed.sol
View File

@ -10,3 +10,4 @@ contract C {
} }
} }
// ---- // ----
// Warning 6328: (163-180): CHC: Assertion violation might happen here.

3
test/libsolidity/smtCheckerTests/operators/slice_default_end.sol
View File

@ -12,6 +12,9 @@ contract C {
} }
} }
// ---- // ----
// Warning 6328: (221-253): CHC: Assertion violation might happen here.
// Warning 6328: (257-289): CHC: Assertion violation might happen here.
// Warning 6328: (293-326): CHC: Assertion violation might happen here.
// Warning 4661: (221-253): BMC: Assertion violation happens here. // Warning 4661: (221-253): BMC: Assertion violation happens here.
// Warning 4661: (257-289): BMC: Assertion violation happens here. // Warning 4661: (257-289): BMC: Assertion violation happens here.
// Warning 4661: (293-326): BMC: Assertion violation happens here. // Warning 4661: (293-326): BMC: Assertion violation happens here.

1
test/libsolidity/smtCheckerTests/operators/slice_default_start.sol
View File

@ -9,5 +9,6 @@ contract C {
} }
} }
// ---- // ----
// Warning 6328: (157-189): CHC: Assertion violation might happen here.
// Warning 6328: (193-225): CHC: Assertion violation happens here. // Warning 6328: (193-225): CHC: Assertion violation happens here.
// Warning 4661: (157-189): BMC: Assertion violation happens here. // Warning 4661: (157-189): BMC: Assertion violation happens here.