cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #14276 from ethereum/smtchecker-fix-ice

Browse Source 
SMTChecker: External function call with struct member is not getter
This commit is contained in:
Leo 2023-05-30 13:46:35 +02:00 committed by GitHub
commit a0933fa80a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 35 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libsolidity/formal/SMTEncoder.cpp
View File

@ -2839,7 +2839,8 @@ smtutil::Expression SMTEncoder::contractAddressValue(FunctionCall const& _f)
VariableDeclaration const* SMTEncoder::publicGetter(Expression const& _expr) const {
if (auto memberAccess = dynamic_cast<MemberAccess const*>(&_expr))
return dynamic_cast<VariableDeclaration const*>(memberAccess->annotation().referencedDeclaration);
if (auto variableDeclaration = dynamic_cast<VariableDeclaration const*>(memberAccess->annotation().referencedDeclaration))
return variableDeclaration->isStateVariable() ? variableDeclaration : nullptr;
return nullptr;
}

33
test/libsolidity/smtCheckerTests/types/struct/struct_external_function_pointer.sol Normal file
View File

@ -0,0 +1,33 @@
struct S {
function() external returns (uint) x;
}
contract C {
function X() public pure returns (uint) {
return 1;
}
uint y;
uint z;
function setZ(uint _z) public {
z = _z;
}
function f() public returns (uint) {
S memory s;
s.x = this.X;
require(y == 0);
require(z == 0);
uint ret = s.x();
assert(y == 0); // should hold
assert(z == 0); // can report violation due to overapproximation after externall call s.x()
return ret;
}
}
// ----
// Warning 6328: (431-445): CHC: Assertion violation happens here.
// Info 1391: CHC: 1 verification condition(s) proved safe! Enable the model checker option "show proved safe" to see all of them.