From 546b08c158723d560b8eb4c78032043338e65590 Mon Sep 17 00:00:00 2001 From: Bhargava Shastry Date: Mon, 15 Oct 2018 17:44:46 +0200 Subject: [PATCH 1/2] Fix compiler warning: clang-8 warns of explicitly-defined op implicitly deleted for Expression object's copy and move constructors --- libsolidity/formal/SolverInterface.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/libsolidity/formal/SolverInterface.h b/libsolidity/formal/SolverInterface.h index 8bbd04173..2c4509424 100644 --- a/libsolidity/formal/SolverInterface.h +++ b/libsolidity/formal/SolverInterface.h @@ -62,8 +62,6 @@ public: Expression(Expression const&) = default; Expression(Expression&&) = default; - Expression& operator=(Expression const&) = default; - Expression& operator=(Expression&&) = default; bool hasCorrectArity() const { From 67fd3ca4a7089fbfcda9cafd15ddfb281ead85c9 Mon Sep 17 00:00:00 2001 From: Bhargava Shastry Date: Wed, 17 Oct 2018 16:46:18 +0200 Subject: [PATCH 2/2] Retained move/copy semantics; removed const qualifier from Expression's members name (of type std::string) and arguments (of type std::vector) --- libsolidity/formal/SolverInterface.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libsolidity/formal/SolverInterface.h b/libsolidity/formal/SolverInterface.h index 2c4509424..af1cc8e40 100644 --- a/libsolidity/formal/SolverInterface.h +++ b/libsolidity/formal/SolverInterface.h @@ -62,6 +62,8 @@ public: Expression(Expression const&) = default; Expression(Expression&&) = default; + Expression& operator=(Expression const&) = default; + Expression& operator=(Expression&&) = default; bool hasCorrectArity() const { @@ -169,8 +171,8 @@ public: } } - std::string const name; - std::vector const arguments; + std::string name; + std::vector arguments; Sort sort; private: