cerc-io/solidity
11
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix for constant strings.

Browse Source
This commit is contained in:
chriseth
2015-09-08 16:51:14 +02:00
parent ea981cb0f5
commit 985eb80695
4 changed files with 60 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libsolidity/AST.cpp
+16 -6
View File
@@ -81,15 +81,16 @@ void ContractDefinition::checkTypeRequirements()
if (!function->isFullyImplemented())
setFullyImplemented(false);
}
for (ASTPointer<VariableDeclaration> const& variable: m_stateVariables)
variable->checkTypeRequirements();
for (ASTPointer<ModifierDefinition> const& modifier: functionModifiers())
modifier->checkTypeRequirements();
for (ASTPointer<FunctionDefinition> const& function: definedFunctions())
function->checkTypeRequirements();
for (ASTPointer<VariableDeclaration> const& variable: m_stateVariables)
variable->checkTypeRequirements();
checkExternalTypeClashes();
// check for hash collisions in function signatures
set<FixedHash<4>> hashes;
@@ -559,9 +560,18 @@ void VariableDeclaration::checkTypeRequirements()
BOOST_THROW_EXCEPTION(createTypeError("Illegal use of \"constant\" specifier."));
if (!m_value)
BOOST_THROW_EXCEPTION(createTypeError("Uninitialized \"constant\" variable."));
else if (m_type && !m_type->isValueType())
// TODO: const is implemented only for uint, bytesXX and enums types.
BOOST_THROW_EXCEPTION(createTypeError("Illegal use of \"constant\" specifier. \"constant\" is not implemented for this type yet."));
if (m_type && !m_type->isValueType())
{
// TODO: const is implemented only for uint, bytesXX, string and enums types.
bool constImplemented = false;
if (auto arrayType = dynamic_cast<ArrayType const*>(m_type.get()))
constImplemented = arrayType->isByteArray();
if (!constImplemented)
BOOST_THROW_EXCEPTION(createTypeError(
"Illegal use of \"constant\" specifier. \"constant\" "
" is not yet implemented for this type."
));
}
}
if (m_type)
{