cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #6636 from ethereum/smt_fix_constructor

Browse Source 
[SMTChecker] Fix bad cast in base constructor modifier.
This commit is contained in:
chriseth 2019-05-02 09:50:24 +02:00 committed by GitHub
commit 90f2fe6fd0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changelog.md
View File

@ -7,6 +7,7 @@ Compiler Features:
Bugfixes: Bugfixes:
* SMTChecker: Fix bad cast in base constructor modifier.

9
libsolidity/formal/SMTChecker.cpp
View File

@ -101,13 +101,18 @@ bool SMTChecker::visit(ModifierDefinition const&)
bool SMTChecker::visit(FunctionDefinition const& _function) bool SMTChecker::visit(FunctionDefinition const& _function)
{ {
m_functionPath.push_back(&_function);
m_modifierDepthStack.push_back(-1);
if (_function.isConstructor()) if (_function.isConstructor())
{
m_errorReporter.warning( m_errorReporter.warning(
_function.location(), _function.location(),
"Assertion checker does not yet support constructors." "Assertion checker does not yet support constructors."
); );
m_functionPath.push_back(&_function); return false;
m_modifierDepthStack.push_back(-1); }
// Not visited by a function call // Not visited by a function call
if (isRootFunction()) if (isRootFunction())
{ {

6
test/libsolidity/smtCheckerTests/functions/constructor_hierarchy.sol Normal file
View File

@ -0,0 +1,6 @@
pragma experimental SMTChecker;
contract C { constructor(uint) public {} }
contract A is C { constructor() C(2) public {} }
// ----
// Warning: (45-72): Assertion checker does not yet support constructors.
// Warning: (93-121): Assertion checker does not yet support constructors.

10
test/libsolidity/smtCheckerTests/functions/constructor_hierarchy_2.sol Normal file
View File

@ -0,0 +1,10 @@
pragma experimental SMTChecker;
contract C { constructor(uint) public {} }
contract A is C { constructor() C(2) public {} }
contract B is C { constructor() C(3) public {} }
contract J is C { constructor() C(3) public {} }
// ----
// Warning: (45-72): Assertion checker does not yet support constructors.
// Warning: (93-121): Assertion checker does not yet support constructors.
// Warning: (142-170): Assertion checker does not yet support constructors.
// Warning: (191-219): Assertion checker does not yet support constructors.