cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #6817 from ethereum/const-opt-comments

Browse Source 
Document copyRoutine in ConstantOptimiser
This commit is contained in:
chriseth 2019-05-22 17:22:19 +02:00 committed by GitHub
commit 8ebf057b5c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
libevmasm/ConstantOptimiser.cpp
View File

@ -151,6 +151,7 @@ bigint CodeCopyMethod::gasNeeded() const
AssemblyItems CodeCopyMethod::execute(Assembly& _assembly) const AssemblyItems CodeCopyMethod::execute(Assembly& _assembly) const
{ {
bytes data = toBigEndian(m_value); bytes data = toBigEndian(m_value);
assertThrow(data.size() == 32, OptimizerException, "Invalid number encoding.");
AssemblyItems actualCopyRoutine = copyRoutine(); AssemblyItems actualCopyRoutine = copyRoutine();
actualCopyRoutine[4] = _assembly.newData(data); actualCopyRoutine[4] = _assembly.newData(data);
return actualCopyRoutine; return actualCopyRoutine;
@ -159,15 +160,25 @@ AssemblyItems CodeCopyMethod::execute(Assembly& _assembly) const
AssemblyItems const& CodeCopyMethod::copyRoutine() AssemblyItems const& CodeCopyMethod::copyRoutine()
{ {
AssemblyItems static copyRoutine{ AssemblyItems static copyRoutine{
// constant to be reused 3+ times
u256(0), u256(0),
// back up memory
// mload(0)
Instruction::DUP1, Instruction::DUP1,
Instruction::MLOAD, // back up memory Instruction::MLOAD,
// codecopy(0, <offset>, 32)
u256(32), u256(32),
AssemblyItem(PushData, u256(1) << 16), // has to be replaced AssemblyItem(PushData, u256(1) << 16), // replaced above in actualCopyRoutine[4]
Instruction::DUP4, Instruction::DUP4,
Instruction::CODECOPY, Instruction::CODECOPY,
// mload(0)
Instruction::DUP2, Instruction::DUP2,
Instruction::MLOAD, Instruction::MLOAD,
// restore original memory
Instruction::SWAP2, Instruction::SWAP2,
Instruction::MSTORE Instruction::MSTORE
}; };