Merge pull request #8458 from a3d4/partfix-8244-introduced-testcase-shouldrun

Partial Fix #8244: Introduced TestCase::shouldRun().

test/libyul/SyntaxTest.cpp

@@ -114,13 +114,12 @@ void SyntaxTest::parseAndAnalyze()
 
 }
 
-bool SyntaxTest::validateSettings(langutil::EVMVersion _evmVersion)
+void SyntaxTest::validateSettings()
 {
-	if (!CommonSyntaxTest::validateSettings(_evmVersion))
-		return false;
+	CommonSyntaxTest::validateSettings();
 
 	if (!m_settings.count("dialect"))
-		return true;
+		return;
 
 	string const dialect = m_settings["dialect"];
 	m_validatedSettings["dialect"] = dialect;
@@ -134,6 +133,4 @@ bool SyntaxTest::validateSettings(langutil::EVMVersion _evmVersion)
 			joinHumanReadable(validDialectNames(), ", ", " and ") +
 			"."
 		});
-
-	return true;
 }

test/libyul/SyntaxTest.h

@@ -42,10 +42,7 @@ public:
 
 	/// Validates the settings, i.e. moves them from m_settings to m_validatedSettings.
 	/// Throws a runtime exception if any setting is left at this class (i.e. unknown setting).
-	/// Returns true, if the test case is supported in the current environment and false
-	/// otherwise which causes this test to be skipped.
-	/// This might check e.g. for restrictions on the EVM version.
-	bool validateSettings(langutil::EVMVersion _evmVersion) override;
+	void validateSettings() override;
 protected:
 	void parseAndAnalyze() override;
 };