cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

defaulting to v0.5.0 behaviour of unary + operator (disallow); also adapting all tests to it

Browse Source
This commit is contained in:
Christian Parpart 2018-07-03 11:10:14 +02:00 committed by chriseth
parent 4547b32348
commit 8ca69ed8d8
5 changed files with 4 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libsolidity/analysis/SyntaxChecker.cpp
View File

@ -192,15 +192,9 @@ bool SyntaxChecker::visit(Throw const& _throwStatement)
bool SyntaxChecker::visit(UnaryOperation const& _operation) bool SyntaxChecker::visit(UnaryOperation const& _operation)
{ {
bool const v050 = m_sourceUnit->annotation().experimentalFeatures.count(ExperimentalFeature::V050);
if (_operation.getOperator() == Token::Add) if (_operation.getOperator() == Token::Add)
{ m_errorReporter.syntaxError(_operation.location(), "Use of unary + is disallowed.");
if (v050)
m_errorReporter.syntaxError(_operation.location(), "Use of unary + is deprecated.");
else
m_errorReporter.warning(_operation.location(), "Use of unary + is deprecated.");
}
return true; return true;
} }

2
test/libsolidity/syntaxTests/nameAndTypeResolution/308_rational_unary_plus_operation.sol
View File

@ -6,4 +6,4 @@ contract test {
} }
} }
// ---- // ----
// Warning: (70-75): Use of unary + is deprecated. // SyntaxError: (70-75): Use of unary + is disallowed.

10
test/libsolidity/syntaxTests/nameAndTypeResolution/310_rational_unary_plus_operation_v050.sol
View File

@ -1,10 +0,0 @@
pragma experimental "v0.5.0";
contract test {
function f() pure public {
ufixed16x2 a = +3.25;
fixed16x2 b = -3.25;
a; b;
}
}
// ----
// SyntaxError: (100-105): Use of unary + is deprecated.

9
test/libsolidity/syntaxTests/nameAndTypeResolution/311_rational_unary_plus_assignment_v050.sol
View File

@ -1,9 +0,0 @@
pragma experimental "v0.5.0";
contract test {
function f(uint x) pure public {
uint y = +x;
y;
}
}
// ----
// SyntaxError: (100-102): Use of unary + is deprecated.

2
test/libsolidity/syntaxTests/nameAndTypeResolution/309_rational_unary_plus_assignment.sol → test/libsolidity/syntaxTests/parsing/unary_plus_expression.sol
View File

@ -5,4 +5,4 @@ contract test {
} }
} }
// ---- // ----
// Warning: (70-72): Use of unary + is deprecated. // SyntaxError: (70-72): Use of unary + is disallowed.