cerc-io/solidity
11
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

functions taking calldata args should be assignable to function pointers of same type

Browse Source
This commit is contained in:
nishant-sachdeva
2022-10-26 13:29:02 +05:30
parent 799ef0ab1a
commit 8c0740748e
5 changed files with 54 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/types/value-types.rst
+12
View File
@@ -789,6 +789,18 @@ This includes private, internal and public functions of both contracts and libra
functions.
External function types, on the other hand, are only compatible with public and external contract
functions.
.. note::
External functions with ``calldata`` parameters are incompatible with external function types with ``calldata`` parameters.
They are compatible with the corresponding types with ``memory`` parameters instead.
For example, there is no function that can be pointed at by a value of type ``function (string calldata) external`` while
``function (string memory) external`` can point at both ``function f(string memory) external {}`` and
``function g(string calldata) external {}``.
This is because for both locations the arguments are passed to the function in the same way.
The caller cannot pass its calldata directly to an external function and always ABI-encodes the arguments into memory.
Marking the parameters as ``calldata`` only affects the implementation of the external function and is
meaningless in a function pointer on the caller's side.
Libraries are excluded because they require a ``delegatecall`` and use :ref:`a different ABI
convention for their selectors <library-selectors>`.
Functions declared in interfaces do not have definitions so pointing at them does not make sense either.