cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix invalid "explicit storage keyword" warning for reference members of structs.

Browse Source
This commit is contained in:
chriseth 2017-07-10 18:30:41 +02:00
parent aafcc3606c
commit 883666d2c0
3 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changelog.md
View File

@ -3,6 +3,7 @@
Features: Features:
Bugfixes: Bugfixes:
* Type Checker: Fix invalid "specify storage keyword" warning for reference members of structs.
### 0.4.13 (2017-07-06) ### 0.4.13 (2017-07-06)

2
libsolidity/analysis/ReferencesResolver.cpp
View File

@ -295,7 +295,7 @@ void ReferencesResolver::endVisit(VariableDeclaration const& _variable)
else else
{ {
typeLoc = DataLocation::Storage; typeLoc = DataLocation::Storage;
if (!_variable.isStateVariable()) if (_variable.isLocalVariable())
m_errorReporter.warning( m_errorReporter.warning(
_variable.location(), _variable.location(),
"Variable is declared as a storage pointer. " "Variable is declared as a storage pointer. "

2
test/libsolidity/SolidityNameAndTypeResolution.cpp
View File

@ -6160,7 +6160,7 @@ BOOST_AUTO_TEST_CASE(warn_unspecified_storage)
{ {
char const* text = R"( char const* text = R"(
contract C { contract C {
struct S { uint a; } struct S { uint a; string b; }
S x; S x;
function f() { function f() {
S storage y = x; S storage y = x;